[Blazor] Correctly encode non-ASCII characters in redirect URL #53623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
commented
Jan 25, 2024
| @@ -11,7 +11,7 @@ internal sealed class HttpNavigationManager : NavigationManager, IHostEnvironmen | |||
|
|
|||
| protected override void NavigateToCore(string uri, NavigationOptions options) | |||
| { | |||
| var absoluteUriString = ToAbsoluteUri(uri).ToString(); | |||
| var absoluteUriString = ToAbsoluteUri(uri).AbsoluteUri; | |||
There was a problem hiding this comment.
Accessing the Uri.AbsoluteUri property will throw if the Uri instance does not represent an absolute URI, but this case is safe because ToAbsoluteUri() always returns an absolute URI.
javiercn
approved these changes
Jan 26, 2024
MackinnonBuck
added a commit
that referenced
this pull request
Jan 26, 2024
This was referenced Jan 26, 2024
ghost
added
the
area-infrastructure
wtgodbe
pushed a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly encode non-ASCII characters in redirect URL
Encodes non-ASCII characters included in redirect URLs.
Description
The culprit was the use of
Uri.ToString(), which decodes URL-encoded characters. This PR replaces the relevant occurrences ofUri.ToString()withUri.AbsoluteUri, which does not perform any decoding.Fixes #52438