Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match arguments and property names in UserLoginInfo #54298

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Mar 1, 2024

Without matching names, since there is no default constructor, System.Text.Json deserialization fails and requires a custom converter.

/cc @eiriktsarpalis

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-identity Includes: Identity and providers label Mar 1, 2024
@MikeAlhayek
Copy link

@sebastienros additionally, why not adding a parameter-less constructor for this class? None of the properties are encapsulated and can be publicly set.

@sebastienros
Copy link
Member Author

Not necessary, and it has required arguments.

@MikeAlhayek
Copy link

Not necessary, and it has required arguments.

But helpful. and since all the properties are mutable, I don't see why not.

@sebastienros
Copy link
Member Author

File an issue. Pick your battles.

@eiriktsarpalis
Copy link
Member

Not necessary, and it has required arguments.

But helpful. and since all the properties are mutable, I don't see why not.

It would necessitate marking the string properties as nullable, since a default constructor makes null values possible.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 12, 2024
@danmoseley danmoseley merged commit 5c52ed9 into main Feb 14, 2025
26 checks passed
@danmoseley danmoseley deleted the sebros/userlogininfo branch February 14, 2025 04:06
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants