Skip to content

Add readme for package Microsoft.AspNetCore.Authentication.JwtBearer #54492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Mar 12, 2024

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Include readme for NuGet package: Microsoft.AspNetCore.Authentication.JwtBearer

Fixes #{bug number} (in this specific format)

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2024
@mkArtakMSFT mkArtakMSFT requested a review from halter73 March 12, 2024 16:27
@mkArtakMSFT
Copy link
Member

Thank you, @lyndaidaii.
@halter73 can you please review the text for the package? Thanks!

@lyndaidaii
Copy link
Contributor Author

I only add readme context, it needs include it when build a package. Not sure about how AspnetCore packages build process possible MSbuild. Please help include it when build a package, thanks.

@halter73
Copy link
Member

We don't have any PACKAGE.md files in this repo. The NuGet package metadata comes from the cproj's "Description" property and then augmented with a link to the commit that produced it here.

I'm not sure how difficult it would be to source the package description from PACKAGE.md. It seems like it wouldn't be too difficult using the ReadLinesFromFile MSBuild Task, but I don't think it's something we have the time to do ourselves right now. And if we're going to start with more involved NuGet package descriptions, it's not clear we'd start with Microsoft.AspNetCore.Authentication.JwtBearer.

Thank you for your contribution, but I think we should probably close this. @wtgodbe What do you think?

@lyndaidaii
Copy link
Contributor Author

lyndaidaii commented Mar 12, 2024

I am from NuGet team, we are adding readme for top installed aspnetcore packages on NuGet.org. We are helping to generate readme for top 5 installed aspnetcore packages. I am following the template from .NET runtime. We worked with them previously, they are using MSbuild to include the package readme file into package while building. I could help check with their team see how they build it with readme by using MSbuild. If is easy, I could help with PR as well if is public repository.

@wtgodbe
Copy link
Member

wtgodbe commented Mar 12, 2024

@lyndaidaii can you provide more info on the difference between the package description in the .csproj, and this readme file? Do either show up on nuget.org?

If Nuget has a goal to get READMEs into the top 5 packages from each repo, it should be pretty easy to get this included in the package - we can probably do it w/ msbuild in the same way dotnet/runtime does.

@lyndaidaii
Copy link
Contributor Author

@lyndaidaii can you provide more info on the difference between the package description in the .csproj, and this readme file? Do either show up on nuget.org?

A package without readme, it will show package description as default on readme tab on NuGet.org.
For example, the JwtBearer doesn't have a readme instead it shows package description.
image

A package with readme, it will show readme on NuGet.org. An example for .NET package:
image

Difference between package description vs readme:

  1. README on NuGet.org support most GitHub flavor markdown, package description only support text render.
  2. README provides important information to users and helps them understand what the package is and what it does quickly, package description is summary of packages, not useful to help users to get started with packages
  3. We are working on rendering readme on PMUI in Visual Studio
  4. README is metadata of packages, similar to package description, you could reference a README in your .csproj, here is more details: https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#packagereadmefile

If Nuget has a goal to get READMEs into the top 5 packages from each repo, it should be pretty easy to get this included in the package - we can probably do it w/ msbuild in the same way dotnet/runtime does.

@ViktorHofer is driving README work for dotnet runtime team. here is issue: https://github.com/dotnet/runtime/pull/91210/files
Free feel to reach out to Viktor about how they build readme file with package using MSbuild.

Please let me know if you have any other question. I will create an issue on this repo that track the packages to include the readme. Thanks.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 20, 2024
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Nuget has a goal to get READMEs into the top 5 packages from each repo, it should be pretty easy to get this included in the package - we can probably do it w/ msbuild in the same way dotnet/runtime does.

@wtgodbe I'm not sure if there's anything more to do or if arcade will pick it up automatically. I guess we can keep an eye on nuget.org.

I see no reason to hold off merging this considering we've already merged #54504 which adds another PACKAGE.md file.

@halter73 halter73 merged commit 7033ec7 into dotnet:main Apr 19, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 19, 2024
@halter73 halter73 removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 19, 2024
@halter73
Copy link
Member

Thanks @lyndaidaii!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-security community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants