-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add readme for package Microsoft.AspNetCore.Authentication.JwtBearer #54492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you, @lyndaidaii. |
I only add readme context, it needs include it when build a package. Not sure about how AspnetCore packages build process possible MSbuild. Please help include it when build a package, thanks. |
We don't have any I'm not sure how difficult it would be to source the package description from Thank you for your contribution, but I think we should probably close this. @wtgodbe What do you think? |
I am from NuGet team, we are adding readme for top installed aspnetcore packages on NuGet.org. We are helping to generate readme for top 5 installed aspnetcore packages. I am following the template from .NET runtime. We worked with them previously, they are using MSbuild to include the package readme file into package while building. I could help check with their team see how they build it with readme by using MSbuild. If is easy, I could help with PR as well if is public repository. |
@lyndaidaii can you provide more info on the difference between the package description in the .csproj, and this readme file? Do either show up on nuget.org? If Nuget has a goal to get READMEs into the top 5 packages from each repo, it should be pretty easy to get this included in the package - we can probably do it w/ msbuild in the same way dotnet/runtime does. |
A package without readme, it will show package description as default on readme tab on NuGet.org. A package with readme, it will show readme on NuGet.org. An example for .NET package: Difference between package description vs readme:
@ViktorHofer is driving README work for dotnet runtime team. here is issue: https://github.com/dotnet/runtime/pull/91210/files Please let me know if you have any other question. I will create an issue on this repo that track the packages to include the readme. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Nuget has a goal to get READMEs into the top 5 packages from each repo, it should be pretty easy to get this included in the package - we can probably do it w/ msbuild in the same way dotnet/runtime does.
@wtgodbe I'm not sure if there's anything more to do or if arcade will pick it up automatically. I guess we can keep an eye on nuget.org.
I see no reason to hold off merging this considering we've already merged #54504 which adds another PACKAGE.md file.
Thanks @lyndaidaii! |
{PR title}
Summary of the changes (Less than 80 chars)
Description
Include readme for NuGet package: Microsoft.AspNetCore.Authentication.JwtBearer
Fixes #{bug number} (in this specific format)