Skip to content

Fix dockerfile references for helix #54752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2024
Merged

Fix dockerfile references for helix #54752

merged 2 commits into from
Mar 26, 2024

Conversation

radical
Copy link
Member

@radical radical commented Mar 25, 2024

  • [helix] Change fedora-39-helix to fedora-38-helix, as the dockerfile for the former does not exist
  • [helix] Fix image reference cbl-mariner-2.0-helix to cbl-mariner-2.0-helix-amd64

@radical radical requested review from wtgodbe and a team as code owners March 25, 2024 21:17
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 25, 2024
@radical radical removed the arch-wasm label Mar 25, 2024
@radical
Copy link
Member Author

radical commented Mar 25, 2024

aspnetcore-quarantied-tests fails only with the test failures now - https://dev.azure.com/dnceng-public/public/_build/results?buildId=617634&view=results
aspnetcore-helix-matrix - waiting on https://dev.azure.com/dnceng-public/public/_build/results?buildId=617621&view=results

@radical
Copy link
Member Author

radical commented Mar 26, 2024

@wtgodbe can this PR be merged? It fixes the dockerfile references as intended.
And the test failures are unrelated and being tracked in #54754 and #54757 .

@wtgodbe wtgodbe merged commit f9c4b98 into dotnet:main Mar 26, 2024
25 of 28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Mar 26, 2024
@radical radical deleted the helix-queue-fix branch March 26, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
9.0-preview4
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @wtgodbe