Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AccountLayout.razor from project template #55294

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

halter73
Copy link
Member

After #55157, the AccountLayout from the Blazor Web project template should no longer be necessary. It didn't add any UI. Instead, it just checked if the component was rendering in interactive mode, and if so, called NavigationManager.Refresh(forceReload: true) and showed <p>Loading...</p> in the meantime.

The ManageLayout.razor which renders an account management submenu remains.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Apr 22, 2024
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks very neat.

I can't predict just by reading it whether it still works correctly (since auth may have other special requirements) but assuming it does, great!

@halter73 halter73 merged commit 9755a3a into main Apr 24, 2024
23 of 26 checks passed
@halter73 halter73 deleted the halter73/remove-account-layout branch April 24, 2024 00:00
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants