Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary pragmas #55810

Merged
merged 4 commits into from
May 28, 2024
Merged

Remove unnecessary pragmas #55810

merged 4 commits into from
May 28, 2024

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented May 20, 2024

...now that dotnet/linker#2715 has been fixed.

@amcasey
Remove unnecessary pragmas
1179ecb 
...now that dotnet/linker#2715 has been fixed.
@amcasey amcasey requested a review from eerhardt May 20, 2024 20:03
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label May 20, 2024
eerhardt
eerhardt reviewed May 20, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix build

@mkArtakMSFT mkArtakMSFT added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels May 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 28, 2024
eerhardt
eerhardt approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcasey amcasey merged commit f8c9806 into main May 28, 2024
26 checks passed
@amcasey amcasey deleted the amcasey-patch-2 branch May 28, 2024 22:20
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview6 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@javiercn javiercn Awaiting requested review from javiercn javiercn is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
9.0-preview6
Development

Successfully merging this pull request may close these issues.
3 participants
@amcasey @eerhardt @mkArtakMSFT