Skip to content

Conversation

@halter73
Copy link
Member

A lot of our test certs in release/6.0's src/Shared/test/Certificates/ directory expired on Friday, May 17th. This PR cherry-picks #39685 to dynamically generate these certs so they don't expire again. This should unblock our dependency update at #55798.

@halter73 halter73 requested a review from wtgodbe May 20, 2024 20:29
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 20, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 6.0.x milestone May 20, 2024
namespace Microsoft.AspNetCore.Authentication.Certificate.Test
{
public class ClientCertificateAuthenticationTests
public class ClientCertificateAuthenticationTests : LoggedTest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label May 20, 2024
@wtgodbe
Copy link
Member

wtgodbe commented May 20, 2024

Marking as tell-mode since this is test-only

@halter73
Copy link
Member Author

@dotnet/aspnet-build Can someone merge this?

@BrennanConroy
Copy link
Member

Can someone merge this?

Patch merge windows apply to tell-mode changes too. You'll need to wait for the next window.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 29, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 4, 2024
@wtgodbe wtgodbe merged commit 941f351 into release/6.0 Jun 4, 2024
@wtgodbe wtgodbe deleted the halter73/fix-expired-certs-6.0 branch June 4, 2024 19:25
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 6.0.x, 6.0.31 Jun 4, 2024
@wtgodbe wtgodbe modified the milestones: 6.0.31, 6.0.32 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants