[Blazor] Rename ComponentPlatform to RendererInfo #56263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-blazor
javiercn
force-pushed
the
javiercn/rename-component-platform-to-renderer-info
branch
from
d0b90cc to
c1cfe2e
Compare
| /// <summary> | ||
| /// Gets the name of the platform. | ||
| /// </summary> | ||
| public string Name { get; } = rendererName; |
There was a problem hiding this comment.
This is just academic, but I'm curious how this differs from:
public string Name => rendererName;I would have thought doing it like this reduces the amount of storage required since we're reading the primary constructor's generated field directly instead of copying it into another field on construction, but maybe the compiler optimizes it to be the same regardless.
Not a big deal but if you happen to know then I'm interested!
There was a problem hiding this comment.
The compiler optimizes that afaik.
There was a problem hiding this comment.
Yeah I was curious and checked; the generated code is virtually identical. In both cases there's only one backing field.
SteveSandersonMS
approved these changes
Jun 17, 2024
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
3 tasks
This was referenced Jul 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames as per #56047 (comment)
Fixes #56047