[release/9.0-preview7] Make ApiExplorer for minimal APIs trim-compatible #56937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
captainsafia,
a team,
halter73,
brunolins16,
javiercn,
BrennanConroy and
wtgodbe
as code owners
dotnet-issue-labeler
bot
added
the
area-infrastructure
captainsafia
added
the
Servicing-consider
wtgodbe
added
Servicing-approved
BrennanConroy
approved these changes
Jul 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56827 to release/9.0-preview7
/cc @captainsafia
Make ApiExplorer for minimal APIs trim-compatible
This PR introduces new API and behavior modifications to support making the entire OpenAPI pipeline for minimal APIs in ASP.NET Core trimming and native AoT-compatible.
Description
Changes introduced in this PR include:
IParameterBindingMetadataAPIRequestDelegateGeneratorandRequestDelegateFactoryto support emittingIParameterBindingMetadatafor each endpointRequestDelegateGeneratorandRequestDelegateFactoryto support emitting response metadata for handlers that return awaitable responsesIParameterBindingMetadataand response metadataModelMetadatain MVC abstractions to support trim and AoT-compatabilityFixes #56023
Customer Impact
Native AoT support is a differentiation for built-in OpenAPI support and allows us to continue our commitment to make new features for minimal API native AoT-compatible by default.
Regression?
Risk
This changeset carries medium risk, so we'd like to merge it into preview.7 to identify any potential issues related with the changes including:
Verification
Packaging changes reviewed?