Skip to content

Upgrade yarn dependencies #57092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

MackinnonBuck
Copy link
Member

Upgraded:

  • src/Components/Web.JS/yarn.lock
  • src/SignalR/clients/ts/signalr/yarn.lock

By running yarn upgrade

@MackinnonBuck MackinnonBuck added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 30, 2024
@MackinnonBuck MackinnonBuck requested review from BrennanConroy, halter73 and a team as code owners July 30, 2024 21:56
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 30, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.x milestone Jul 30, 2024
@MackinnonBuck
Copy link
Member Author

An unexpected error occurred: "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public-npm/npm/registry/@babel/core/-/core-7.25.2.tgz: Request failed \"401 Unauthorized\""

@wtgodbe Do you know why this might happen? Is there another step required for CI when updating Yarn lockfiles? This doesn't happen when I install packages locally.

@wtgodbe
Copy link
Member

wtgodbe commented Jul 30, 2024

Not sure, I would've thought that if anything, doing a local restore pre-build would pull in the package to our feed. Maybe update the relevant package.json's as well, just in case? If not, maybe someone from @dotnet/dnceng would know more about authenticating to the npm feed

@dougbu
Copy link
Member

dougbu commented Jul 31, 2024

you need to run vsts-npm-auth.cmd -config $PWD\.npmrc or similar (if not in Powershell) to authorize yourself before using yarn upgrade. probably best to clean out npm caches and related folders first. IIRC auth basically switches from letting you pull from the upstream source to pulling from the upstream and updating the dotnet-public-npm feed

@javiercn
Copy link
Member

@wtgodbe should we consider backporting a bunch of the changes we did in this area in the 9.0 timeframe to 8.0?

It would definitely be easier if we could rely on the same infrastructure and just backport updates.

@wtgodbe
Copy link
Member

wtgodbe commented Jul 31, 2024

should we consider backporting a bunch of the changes we did in this area in the 9.0 timeframe to 8.0?

It would definitely be easier if we could rely on the same infrastructure and just backport updates.

I'm on board with it if it makes npm updates easier. Which changes did you have in mind?

@MackinnonBuck MackinnonBuck force-pushed the mbuck/fix-cg-issues-8.0 branch from 186a58d to 869eaa9 Compare July 31, 2024 18:30
@javiercn
Copy link
Member

javiercn commented Jul 31, 2024

should we consider backporting a bunch of the changes we did in this area in the 9.0 timeframe to 8.0?

It would definitely be easier if we could rely on the same infrastructure and just backport updates.

I'm on board with it if it makes npm updates easier. Which changes did you have in mind?

Getting rid of all the yarn related stuff + centralized NPM. The stuff that we did in 9.0 a few months back.

@MackinnonBuck MackinnonBuck force-pushed the mbuck/fix-cg-issues-8.0 branch from 869eaa9 to 538c8c6 Compare July 31, 2024 18:51
@MackinnonBuck
Copy link
Member Author

Hm, still no luck (getting the same "401 Unauthorized" error). I did:

git clean -fdx
npm cache clean --force
vsts-npm-auth.ps1 -config .\.npmrc -F

Then from each folder with a yarn.lock:

yarn upgrade

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Aug 8, 2024
@MackinnonBuck
Copy link
Member Author

/azp run

Copy link

Pull request contains merge conflicts.

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Aug 9, 2024
@MackinnonBuck
Copy link
Member Author

Looks like #56677 already covered this.

@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.9 Aug 9, 2024
@MackinnonBuck MackinnonBuck deleted the mbuck/fix-cg-issues-8.0 branch November 5, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants