Add StringSyntax to the RouteAttribute
#57369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed when using the `[Route("/orders/{orderId:int}")]` attribute, as an example, doesn't display the same as when using the `EndpointRouteBuilderExtensions` APIs for `Map*` that accept a template/pattern. I think it would be great if we could also highlight routes when using the attribute. This PR adds the `StringSyntax` to decorate the `template` parameter to be highlighted like the method APIs.
ghost
added
the
Member
|
CI failures look unrelated - re-running. |
Member
|
Failures appear to be #57416. |
Member
Author
|
Besides discovering unrelated testing issues/concerns, anything else you need from me on the PR @amcasey? |
Member
|
@IEvangelist Sorry, I'm just looking at builds - you'll want a sign-off from one of the blazor devs. |
Member
|
Oh, hey, it finally passed! |
javiercn
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
StringSyntaxto theRouteAttributeYou've included unit or integration tests for your change, where applicable.You've included inline docs for your change, where applicable.Consistent syntax highlighting of template/patterns for routes.
Description
I noticed when using the
[Route("/orders/{orderId:int}")]attribute, as an example, doesn't display the same as when using theEndpointRouteBuilderExtensionsAPIs forMap*that accept a template/pattern.Example
MapGet— includes string syntax:Example
Route— doesn't include string syntax:I think it would be great if we could also highlight routes when using the attribute. This PR adds the
StringSyntaxto decorate thetemplateparameter to be highlighted like the method APIs.Contributes to #44535