Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #57742

Merged
merged 10 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
288 changes: 144 additions & 144 deletions eng/Version.Details.xml

Large diffs are not rendered by default.

144 changes: 72 additions & 72 deletions eng/Versions.props

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions eng/testing/linker/ILLink.Descriptors.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<linker>
<assembly fullname="System.Private.CoreLib">
<type fullname="System.Array" />
</assembly>
</linker>
2 changes: 2 additions & 0 deletions eng/testing/linker/trimmingTests.targets
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@
<Copy SourceFiles="$(_projectSourceFile);
@(_additionalProjectSourceFiles)"
DestinationFolder="$(_projectDir)" />
<Copy SourceFiles="$(MSBuildThisFileDirectory)ILLink.Descriptors.xml"
DestinationFolder="$(_projectDir)" />
<Message Text="Generated $(_projectFile)" />
</Target>

Expand Down Expand Up @@ -123,7 +125,7 @@
<Output TaskParameter="ExitCode" PropertyName="ExecutionExitCode" />
</Exec>

<Error Condition="'$(ExecutionExitCode)' != '100'" Text="Error: [Failed Test]: %(TestConsoleApps.ProjectCompileItems). The Command %(TestConsoleApps.TestCommand) returned a non-success exit code: $(ExecutionExitCode)." ContinueOnError="ErrorAndContinue" />

Check failure on line 128 in eng/testing/linker/trimmingTests.targets

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

eng/testing/linker/trimmingTests.targets#L128

eng/testing/linker/trimmingTests.targets(128,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: [Failed Test]: /mnt/vss/_work/1/s/src/DefaultBuilder/test/Microsoft.AspNetCore.TrimmingTests/SlimBuilderDoesNotDependOnX509Test.cs. The Command /mnt/vss/_work/1/s/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.TrimmingTests/SlimBuilderDoesNotDependOnX509Test/bin/Release/net9.0/linux-x64/publish/project returned a non-success exit code: 134.

Check failure on line 128 in eng/testing/linker/trimmingTests.targets

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

eng/testing/linker/trimmingTests.targets#L128

eng/testing/linker/trimmingTests.targets(128,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: [Failed Test]: /mnt/vss/_work/1/s/src/DefaultBuilder/test/Microsoft.AspNetCore.TrimmingTests/UseHttpsDoesDependOnX509Test.cs. The Command /mnt/vss/_work/1/s/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.TrimmingTests/UseHttpsDoesDependOnX509Test/bin/Release/net9.0/linux-x64/publish/project returned a non-success exit code: 134.

Check failure on line 128 in eng/testing/linker/trimmingTests.targets

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

eng/testing/linker/trimmingTests.targets#L128

eng/testing/linker/trimmingTests.targets(128,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: [Failed Test]: /mnt/vss/_work/1/s/src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.TrimmingTests/TestTypedClients.cs. The Command /mnt/vss/_work/1/s/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.SignalR.TrimmingTests/TestTypedClients/bin/Release/net9.0/linux-x64/publish/project returned a non-success exit code: 134.

Check failure on line 128 in eng/testing/linker/trimmingTests.targets

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

eng/testing/linker/trimmingTests.targets#L128

eng/testing/linker/trimmingTests.targets(128,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: [Failed Test]: /mnt/vss/_work/1/s/src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.TrimmingTests/TestCertificateXmlEncryptor.cs. The Command /mnt/vss/_work/1/s/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.DataProtection.TrimmingTests/TestCertificateXmlEncryptor/bin/Release/net9.0/linux-x64/publish/project returned a non-success exit code: 134.

Check failure on line 128 in eng/testing/linker/trimmingTests.targets

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

eng/testing/linker/trimmingTests.targets#L128

eng/testing/linker/trimmingTests.targets(128,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: [Failed Test]: /mnt/vss/_work/1/s/src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.TrimmingTests/TestEncryptedXmlDecryptor.cs. The Command /mnt/vss/_work/1/s/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.DataProtection.TrimmingTests/TestEncryptedXmlDecryptor/bin/Release/net9.0/linux-x64/publish/project returned a non-success exit code: 134.

Check failure on line 128 in eng/testing/linker/trimmingTests.targets

View check run for this annotation

Azure Pipelines / aspnetcore-ci

eng/testing/linker/trimmingTests.targets#L128

eng/testing/linker/trimmingTests.targets(128,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: [Failed Test]: /mnt/vss/_work/1/s/src/DefaultBuilder/test/Microsoft.AspNetCore.TrimmingTests/SlimBuilderDoesNotDependOnX509Test.cs. The Command /mnt/vss/_work/1/s/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.TrimmingTests/SlimBuilderDoesNotDependOnX509Test/bin/Release/net9.0/linux-x64/publish/project returned a non-success exit code: 134.

Check failure on line 128 in eng/testing/linker/trimmingTests.targets

View check run for this annotation

Azure Pipelines / aspnetcore-ci

eng/testing/linker/trimmingTests.targets#L128

eng/testing/linker/trimmingTests.targets(128,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: [Failed Test]: /mnt/vss/_work/1/s/src/DefaultBuilder/test/Microsoft.AspNetCore.TrimmingTests/UseHttpsDoesDependOnX509Test.cs. The Command /mnt/vss/_work/1/s/artifacts/bin/trimmingTests/projects/Microsoft.AspNetCore.TrimmingTests/UseHttpsDoesDependOnX509Test/bin/Release/net9.0/linux-x64/publish/project returned a non-success exit code: 134.
</Target>

<Target Name="Test" DependsOnTargets="ExecuteApplications" />
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Forms/src/FieldIdentifier.cs
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private static void ParseAccessor<T>(Expression<Func<T>> accessor, out object mo
// so, given that it embeds captured values such as "this". We could consider special-casing
// for "() => something.Member" and building a cache keyed by "something.GetType()" with values
// of type Func<object, object> so we can cheaply map from "something" to "something.Member".
var modelLambda = Expression.Lambda(memberExpression.Expression);
var modelLambda = Expression.Lambda(typeof(Func<object?>), memberExpression.Expression);
var modelLambdaCompiled = (Func<object?>)modelLambda.Compile();
var result = modelLambdaCompiled() ??
throw new ArgumentException("The provided expression must evaluate to a non-null value.");
Expand Down Expand Up @@ -201,7 +201,7 @@ static Func<object, object> CreateAccessor((Type model, MemberInfo member) arg)
private static object GetModelFromIndexer(Expression methodCallExpression)
{
object model;
var methodCallObjectLambda = Expression.Lambda(methodCallExpression!);
var methodCallObjectLambda = Expression.Lambda(typeof(Func<object?>), methodCallExpression!);
var methodCallObjectLambdaCompiled = (Func<object?>)methodCallObjectLambda.Compile();
var result = methodCallObjectLambdaCompiled();
if (result is null)
Expand Down
2 changes: 2 additions & 0 deletions src/SignalR/server/Core/src/DynamicHub.cs
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;
namespace Microsoft.AspNetCore.SignalR;

/// <summary>
/// A base class for SignalR hubs that use <c>dynamic</c> to represent client invocations.
/// </summary>
[RequiresDynamicCode("DynamicHub requires dynamic code generation to construct a call site.")]
public abstract class DynamicHub : Hub
{
private DynamicHubClients? _clients;
Expand Down
2 changes: 2 additions & 0 deletions src/SignalR/server/Core/src/DynamicHubClients.cs
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;
using Microsoft.AspNetCore.SignalR.Internal;

namespace Microsoft.AspNetCore.SignalR;

/// <summary>
/// A class that provides <c>dynamic</c> access to connections, including the one that sent the current invocation.
/// </summary>
[RequiresDynamicCodeAttribute("DynamicHubClient requires dynamic code generation to construct a call site.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: DynamicHubClients

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what changed that required these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was a result of dotnet/runtime#107638 getting merged.

public class DynamicHubClients
{
private readonly IHubCallerClients _clients;
Expand Down
2 changes: 2 additions & 0 deletions src/SignalR/server/Core/src/Internal/DynamicClientProxy.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;
using System.Dynamic;

namespace Microsoft.AspNetCore.SignalR.Internal;
Expand All @@ -9,6 +10,7 @@ internal sealed class DynamicClientProxy : DynamicObject
{
private readonly IClientProxy _clientProxy;

[RequiresDynamicCodeAttribute("This constructor requires dynamic code generation to construct a call site.")]
public DynamicClientProxy(IClientProxy clientProxy)
{
_clientProxy = clientProxy;
Expand Down
Loading