Skip to content

throw an exception on id.get if session is not available #57902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

throw an exception on id.get if session is not available #57902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Middleware/Session/src/DistributedSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ public string Id
get
{
Load();
if(IsAvailable == false)
{
throw new InvalidOperationException("Session not currently available");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IsAvailable getter already calls Load() internally.
If the plan is to leave this check in place, let's remove the Load() from the line above.

if (_sessionId == null)
{
_sessionId = new Guid(IdBytes).ToString();
Expand Down
Loading