Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add explicit conversion for value-type returning handlers with filters #57966

Merged
merged 2 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Http/Http.Extensions/src/RequestDelegateFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,11 @@ private static Expression MapHandlerReturnTypeToValueTask(Expression methodCall,
}
else
{
if (returnType.IsValueType)
{
return Expression.Call(WrapObjectAsValueTaskMethod, Expression.Convert(methodCall, typeof(object)));
}

return Expression.Call(WrapObjectAsValueTaskMethod, methodCall);
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Testing;

namespace Microsoft.AspNetCore.Routing.Internal;

public partial class RequestDelegateFactoryTests : LoggedTest
{
public static object[][] ValueTypeReturningDelegates =>
[
[(Func<HttpContext, int>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, char>)((HttpContext httpContext) => 'b')],
[(Func<HttpContext, bool>)((HttpContext httpContext) => true)],
[(Func<HttpContext, float>)((HttpContext httpContext) => 4.2f)],
[(Func<HttpContext, double>)((HttpContext httpContext) => 4.2)],
[(Func<HttpContext, decimal>)((HttpContext httpContext) => 4.2m)],
[(Func<HttpContext, long>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, short>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, byte>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, uint>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, ulong>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, ushort>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, sbyte>)((HttpContext httpContext) => 42)]
];

[Theory]
[MemberData(nameof(ValueTypeReturningDelegates))]
public void Create_WithEndpointFilterOnBuiltInValueTypeReturningDelegate_Works(Delegate @delegate)
{
var invokeCount = 0;

RequestDelegateFactoryOptions options = new()
{
EndpointBuilder = CreateEndpointBuilderFromFilterFactories(
[
(routeHandlerContext, next) =>
{
invokeCount++;
return next;
},
(routeHandlerContext, next) =>
{
invokeCount++;
return next;
},
]),
};

var result = RequestDelegateFactory.Create(@delegate, options);
Assert.Equal(2, invokeCount);
}

public static object[][] NullableValueTypeReturningDelegates =>
[
[(Func<HttpContext, int?>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, char?>)((HttpContext httpContext) => 'b')],
[(Func<HttpContext, bool?>)((HttpContext httpContext) => true)],
[(Func<HttpContext, float?>)((HttpContext httpContext) => 4.2f)],
[(Func<HttpContext, double?>)((HttpContext httpContext) => 4.2)],
[(Func<HttpContext, decimal?>)((HttpContext httpContext) => 4.2m)],
[(Func<HttpContext, long?>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, short?>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, byte?>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, uint?>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, ulong?>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, ushort?>)((HttpContext httpContext) => 42)],
[(Func<HttpContext, sbyte?>)((HttpContext httpContext) => 42)]
];

[Theory]
[MemberData(nameof(NullableValueTypeReturningDelegates))]
public void Create_WithEndpointFilterOnNullableBuiltInValueTypeReturningDelegate_Works(Delegate @delegate)
{
var invokeCount = 0;

RequestDelegateFactoryOptions options = new()
{
EndpointBuilder = CreateEndpointBuilderFromFilterFactories(
[
(routeHandlerContext, next) =>
{
invokeCount++;
return next;
},
(routeHandlerContext, next) =>
{
invokeCount++;
return next;
},
]),
};

var result = RequestDelegateFactory.Create(@delegate, options);
Assert.Equal(2, invokeCount);
}
}
Loading