Fix SFX issues causing sdk injestion failures #59398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
jkoritzinsky
requested review from
ViktorHofer
and removed request for
a team
ViktorHofer
approved these changes
Dec 9, 2024
ViktorHofer
reviewed
Dec 9, 2024
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Condition=" '$(UseIisNativeAssets)' == 'true' AND $(BuildNative) " | ||
| <ProjectReference Condition=" '$(UseIisNativeAssets)' == 'true' AND $(BuildNative) AND '$(MSBuildRestoreSessionId)' == ''" |
There was a problem hiding this comment.
Not blocking this PR but what exact error does this fix?
There was a problem hiding this comment.
This fixes the errors in this job (and the DevVersions job): https://dev.azure.com/dnceng-public/public/_build/results?buildId=889734&view=logs&jobId=9050e078-31bf-5111-d8ec-8b6fa95caf9c
wtgodbe
approved these changes
Dec 9, 2024
Open
3 tasks
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
* Add missing publish args for Linux x64/arm64 * Don't reference the vcxproj during restore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks dotnet/sdk#45347
When simplifying the official build YAML, I missed adding the publish argument explicitly for Linux x64/arm64 jobs. Add that flag back.
When building the repo all-up on Windows in one invocation (only done in the VMR), the project reference from the sfxproj to the native project causes issues during Restore. Exclude the reference during restore evaluation.