Fix loading dotnet user-jwts config #59425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-commandlinetools
halter73
requested review from
captainsafia and
MackinnonBuck
and removed request for
captainsafia
| @@ -72,7 +72,7 @@ public void Configure(string? name, JwtBearerOptions options) | |||
| ValidAudiences = audiences, | |||
| ValidAudience = audience, | |||
| ValidateIssuerSigningKey = true, | |||
| IssuerSigningKeys = GetIssuerSigningKeys(configSection, issuers), | |||
| IssuerSigningKeys = GetIssuerSigningKeys(configSection, [issuer, ..issuers]), | |||
There was a problem hiding this comment.
The fact that we didn't pass the standalone issuer here was always a bug, correct?
There was a problem hiding this comment.
It was a regression caused in .NET 9 by #52821. I plan to backport this once approved.
captainsafia
approved these changes
Dec 13, 2024
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/12321516859 |
10 tasks
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58996