Redis distributed cache: add HybridCache usage signal #59543
+61
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-middleware
captainsafia
approved these changes
Dec 18, 2024
DeagleGross
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use
"DC"and"OC"markers on RESP connections to provide a non-intrusive signal that Distributed Cache and Output Cache are being used; sinceHybridCacheis a feature on top ofIDistributedCache, here we add an additional"HC"token to indicate that a RESP connection is being used forHybridCache.We do this by using
IServiceProvider(changing theinternal RedisCacheImpl(...)constructors) to detectHybridCacheas a service. We don't need it to be the officialHybridCachespecifically (as in.AddHybridCache()) - just that aHybridCacheexists. There are no public API or dependency changes required.Note: we will also want to backport this