Skip tests on internal queues too #59574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
Seems like it'd be easier and more future proof if we instead changed the |
Yeah I just got there too, testing that w/ https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore/pullrequest/46296 |
wtgodbe
force-pushed
the
wtgodbe/SkipTestsOpen
branch
from
6e1e619 to
b50f4bb
Compare
|
Alright, this should be a more general-purpose solution now |
BrennanConroy
approved these changes
Dec 20, 2024
|
/backport to release/9.0 |
|
/backport to release/8.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/12426551923 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/12426552541 |
This was referenced Dec 20, 2024
ellahathaway
pushed a commit
to ellahathaway/aspnetcore
that referenced
this pull request
Dec 20, 2024
* Skip tests on internal too * StringComparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run tests on internal queues sometimes (internal PRs, IdentityModel pipeline) - anywhere we skip a test on a specific public queue, we should skip it on the internal queue too.