Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route string syntax for pattern in RouteHandlerServices.Map #59940

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add route string syntax for pattern in RouteHandlerServices.Map #59940

merged 1 commit into from
Jan 30, 2025

Conversation

murshex
Copy link
Contributor

@murshex murshex commented Jan 19, 2025

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Add route string syntax for pattern in RouteHandlerServices.Map. Just that.

Fixes #59939

@murshex murshex requested a review from halter73 as a code owner January 19, 2025 18:29
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jan 19, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 19, 2025
@gfoidl gfoidl added area-routing and removed area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labels Jan 20, 2025
@MackinnonBuck
Copy link
Member

@captainsafia Does this change look good to you? Seems pretty straightforward.

captainsafia
captainsafia approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! RouteHandlerServices.Map isn't an oft-used API but it is helpful to be consistent with our use of [StringSyntax] everywhere.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 30, 2025
@captainsafia captainsafia merged commit 013fd3d into dotnet:main Jan 30, 2025
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Jan 30, 2025
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@murshex @captainsafia
Add route string syntax for pattern in RouteHandlerServices.Map (#59940)
e95688e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-routing community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
10.0-preview2
Development

Successfully merging this pull request may close these issues.

RouteHandlerServices doesn't have route string syntax
4 participants
@murshex @MackinnonBuck @captainsafia @gfoidl