Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/source-build-reference-packages #60032

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 25, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: 34ebb389-daeb-4237-045c-08db4c01eb9e
  • Build: 20250128.4
  • Date Produced: January 28, 2025 7:20:15 PM UTC
  • Commit: 59287e717fd1ef2a82bef9bf1885c85bed6eb89b
  • Branch: refs/heads/main

…ence-packages build 20250124.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607103 -> To Version 10.0.607402
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners January 25, 2025 05:02
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 25, 2025
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

…ence-packages build 20250127.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607103 -> To Version 10.0.607701
…ence-packages build 20250128.4

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607103 -> To Version 10.0.607804
@captainsafia
Copy link
Member

It looks like this build is failing as a result of the changes introduced in dotnet/source-build-reference-packages#1130. The results of the source build point to the dotnet user-jwts CLI tool being the source of the issue although I don't see where in the dependency graph for that project the package gets brought in.

<Usage Id="System.Formats.Asn1" Version="5.0.0" File="src/artifacts/obj/dotnet-user-jwts/project.assets.json" />

All references to System.Formats.Asn1/5.0.0 in this repo are in test code.

@ellahathaway @mthalman @MichaelSimons Is it safe to update the baselines here or is something fishier going on?

@mthalman
Copy link
Member

The changes in dotnet/source-build-reference-packages#1130 removed packages that are not needed in the full VMR build. Some repo source build legs may still be using those packages though. In that case, it is ok to add them to prebuilt baseline.

@captainsafia captainsafia requested a review from a team as a code owner January 29, 2025 17:05
@lewing lewing merged commit a1d5c09 into main Jan 29, 2025
27 checks passed
@lewing lewing deleted the darc-main-c684d050-57b4-459b-bff5-f3a78ae115f9 branch January 29, 2025 19:25
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Jan 29, 2025
captainsafia added a commit that referenced this pull request Feb 11, 2025
#60032)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250124.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607103 -> To Version 10.0.607402

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250127.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607103 -> To Version 10.0.607701

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250128.4

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607103 -> To Version 10.0.607804

* Update SourceBuildPrebuiltBaseline.xml

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Safia Abdalla <safia@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants