Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarantine Http2ConnectionTests.IgnoreNewStreamsDuringClosedConnection test. #60120

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Quarantine Http2ConnectionTests.IgnoreNewStreamsDuringClosedConnection test. #60120

merged 1 commit into from
Feb 3, 2025

Conversation

shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Jan 30, 2025 •
edited by BrennanConroy
Loading

Quarantine Test

Summary of the changes (Less than 80 chars)

Description

Quarantine Http2ConnectionTests.IgnoreNewStreamsDuringClosedConnection test.

For #60111

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jan 30, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 30, 2025
@BrennanConroy
Copy link
Member

Don't put fixes, we want the linked issue to stay open so we can track fixing it and removing it from quarantine.

@shethaadit
Copy link
Contributor Author

Hi @BrennanConroy, I just saw your comments. I have actually raised PRs to fix 3 issues. But as you mentioned, will take care going forward. :)

@BrennanConroy
Copy link
Member

will take care going forward. :)

You can just edit your PR summary to not say fixes.

@shethaadit
Copy link
Contributor Author

Sure, Thank you @BrennanConroy for your suggestion. I have updated comments for other 2 PRs.

@DeagleGross
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@DeagleGross
Copy link
Contributor

blocked by #59788 with error message:

(NETCORE_ENGINEERING_TELEMETRY=NativeToolsBootstrap) Unable to find directory for jdk 11.0.24; please make sure the tool is installed on this image.

Could not find the JDK. Either run D:\a_work\1\s\eng\scripts\InstallJdk.ps1 to install for this repo, or install the JDK globally on your machine (see D:\a_work\1\s\eng..\docs\BuildFromSource.md for details).

@DeagleGross
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@DeagleGross DeagleGross enabled auto-merge (squash) January 31, 2025 18:28
@DeagleGross
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@DeagleGross DeagleGross merged commit 917e0b6 into dotnet:main Feb 3, 2025
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
10.0-preview2
Development

Successfully merging this pull request may close these issues.
3 participants
@shethaadit @BrennanConroy @DeagleGross