Fix condition for BuildAfterTargetingPack #60147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
jkoritzinsky
approved these changes
Feb 1, 2025
akoeplinger
reviewed
Feb 1, 2025
| @@ -76,19 +76,19 @@ | |||
| </MSBuild> | |||
| </Target> | |||
There was a problem hiding this comment.
should GetReferencesProvidedDelayedProjects be filtered out for source build as well?
|
Not working in VMR build, targeting pack layout isn't in the right place. Working on figuring out why |
|
This works in the VMR build now |
wtgodbe
requested review from
JamesNK,
captainsafia and
mgravell
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to build this during source-build, but we do want to build it in the VMR.
Part of #60146
Test build https://dev.azure.com/dnceng/internal/_build/results?buildId=2633084&view=results