NavigateTo does not scroll to the top in internal navigation to same url
#60190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigateTodoes not scroll to the top in internal navigation to same urlDescription
If we use
NavigateTowith same url as the current one or with only query appended, the navigation action finishes with setting the scroll at the top of the page. It happens even if we were not forcing the external navigation (settingforceLoad=false).The change:
Now, we are conditioning the scroll action with the check if internal navigation is not happening for the same path.
isForSamePathcompares ignoring queries.Fixes #40190