Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to NuGet package pruning warnings #60395

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

ViktorHofer
Copy link
Member

Contributes to dotnet/sdk#46829

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.

Resolve warnings that get emitted when building non-source-only.

Contributes to dotnet/sdk#46829

NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.

Resolve warnings that get emitted when building non-source-only.
@Copilot Copilot bot review requested due to automatic review settings February 14, 2025 15:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (10)
  • src/Azure/AzureAppServices.HostingStartup/src/Microsoft.AspNetCore.AzureAppServices.HostingStartup.csproj: Language not supported
  • src/Components/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj: Language not supported
  • src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj: Language not supported
  • src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj: Language not supported
  • src/Servers/IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj: Language not supported
  • src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj: Language not supported
  • src/Testing/src/Microsoft.AspNetCore.InternalTesting.csproj: Language not supported
  • src/Tools/GetDocumentInsider/src/GetDocument.Insider.csproj: Language not supported
  • src/Tools/Microsoft.dotnet-openapi/src/Microsoft.dotnet-openapi.csproj: Language not supported
  • src/Tools/dotnet-sql-cache/src/dotnet-sql-cache.csproj: Language not supported

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 14, 2025
@ViktorHofer ViktorHofer requested review from wtgodbe and a team as code owners February 14, 2025 15:30
@akoeplinger akoeplinger enabled auto-merge (squash) February 14, 2025 16:08
@akoeplinger akoeplinger merged commit a85b55b into main Feb 14, 2025
27 checks passed
@akoeplinger akoeplinger deleted the NuGetPackagePruningReaction2 branch February 14, 2025 17:28
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants