-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid IISHttpServer close race on construction #60399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
I'm not seeing any changes to callbacks, but I'm not really across this part of the codebase, just trying to interpret what you are doing here so I can approve if I can. |
Ah I missed what you meant, I thought you meant you had moved registration of the callbacks as well but you just made sure the native call was after callbacks. |
Avoid throwing in IISHttpServer.ctor by moving the native call into
IServer.StartAsync
, also setting up native to managed callbacks before doing anything else so that if there are any errors native can still tell managed it's shutting down.The
NativeMethods.HttpGetApplicationProperties()
call can throw if the native side is shutting down while the managed side is starting up.Quarantine test tracking: #60482