Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid IISHttpServer close race on construction #60399

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Feb 14, 2025

Avoid throwing in IISHttpServer.ctor by moving the native call into IServer.StartAsync, also setting up native to managed callbacks before doing anything else so that if there are any errors native can still tell managed it's shutting down.

The NativeMethods.HttpGetApplicationProperties() call can throw if the native side is shutting down while the managed side is starting up.

Quarantine test tracking: #60482

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Feb 14, 2025
@BrennanConroy BrennanConroy marked this pull request as ready for review February 19, 2025 18:25
@Copilot Copilot bot review requested due to automatic review settings February 19, 2025 18:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@mitchdenny
Copy link
Member

I'm not seeing any changes to callbacks, but I'm not really across this part of the codebase, just trying to interpret what you are doing here so I can approve if I can.

@BrennanConroy
Copy link
Member Author

@mitchdenny
Copy link
Member

Ah I missed what you meant, I thought you meant you had moved registration of the callbacks as well but you just made sure the native call was after callbacks.

@BrennanConroy BrennanConroy merged commit 512209d into main Feb 20, 2025
27 checks passed
@BrennanConroy BrennanConroy deleted the BrennanConroy-patch-1 branch February 20, 2025 00:26
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants