Add location.reload on rejected Blazor reconnection to ReconnectModal… #60753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-mvc
There was a problem hiding this comment.
PR Overview
This pull request updates the reconnection logic in the Blazor reconnection UI to automatically reload the page when a reconnection attempt is rejected, mirroring the behavior of the default reconnection display.
- Added a new condition to handle the "rejected" state
- Calls location.reload() to force a page refresh upon rejection
Reviewed Changes
| File | Description |
|---|---|
| src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Layout/ReconnectModal.razor.js | Added condition for "rejected" state to invoke location.reload() |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
javiercn
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported here with the new reconnection UI component in the Blazor project template, the client does not automatically reconnect after a developer stops and restarts the app (e.g. in Visual Studio or using dotnet CLI) without closing or refreshing the browser tab.
I tested it in .NET 9 and found that this workflow never worked with customized reconnection UI.
I investigated the differences in implementation of
UserSpecifiedDisplay(used when user has customized reconnection UI) andDefaultReconnectDisplay(used otherwise) and found that the latter has additional call tolocation.reloadwhen it gets rejected by the Blazor server during reconnection attempt. This is what happens when another instance of the app restarts on the same port. The reload is what enables the development workflow described in the issue.I added such call to the
ReconnectModalcomponent to match the expected behavior.Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3489