Use the host version that corresponds with the LKG SDK #60888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use the live host but the one that is also redistributed in the .NET SDK. Unblocks dotnet/sdk#47480
ViktorHofer
requested review from
halter73,
BrennanConroy,
JamesNK,
mgravell,
wtgodbe and
a team
as code owners
dotnet-issue-labeler
bot
added
the
area-infrastructure
akoeplinger
approved these changes
Mar 12, 2025
| @@ -9,20 +9,20 @@ | |||
| <HostArch Condition="'$(Platform)' == 'Win32'">x86</HostArch> | |||
| <HostArch Condition="'$(Platform)' == 'AnyCPU'">x64</HostArch> | |||
| <HostArch Condition="'$(DotNetBuild)' == 'true'">$(TargetArchitecture)</HostArch> | |||
| <LibNetHostPath>$(NuGetPackageRoot)microsoft.netcore.app.host.win-$(HostArch)\$(MicrosoftNETCoreAppRefVersion)\runtimes\win-$(HostArch)\native</LibNetHostPath> | |||
| <LibNetHostPath>$(NuGetPackageRoot)microsoft.netcore.app.host.win-$(HostArch)\$(LibNetHostAppPackVersion)\runtimes\win-$(HostArch)\native</LibNetHostPath> | |||
| <!-- This tools version MUST match the same version as runtime uses to compile libnethost.lib --> | |||
| <PlatformToolsetVersion>143</PlatformToolsetVersion> | |||
| </PropertyGroup> | |||
|
|
|||
| <!-- Platform is different during restore than during build. Therefore, restore everything when not building the product. --> | |||
There was a problem hiding this comment.
maybe we can flow this in via GenerateFiles.csproj too?
There was a problem hiding this comment.
You mean the platform that should be used at restore time?
There was a problem hiding this comment.
yes or restoring the packages in general there
There was a problem hiding this comment.
I think the problem that required this is that the platform negotiation happens at P2P build time. NuGet doesn't see the agreed upon Platform as it trims out P2P properties. The outer context, i.e. GenerateFiles.csproj or Tools.props wouldn't have more information than the infrastructure in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use the live host but the one that is also redistributed in the .NET SDK. This is a small partial revert of bac31da#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bf
Unblocks dotnet/sdk#47480