Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET SDK to 10.0.100-preview.4.25174.4 #61134

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Updates the .NET SDK to version 10.0.100-preview.4.25174.4, which also updates the .NET runtime from version 10.0.0-preview.3.25166.3 to version 10.0.0-preview.4.25173.3.

This pull request was auto-generated by GitHub Actions.

Update .NET SDK to version 10.0.100-preview.4.25174.4.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot requested review from wtgodbe and a team as code owners March 24, 2025 12:13
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 24, 2025
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving SDK update.

@MackinnonBuck
Copy link
Member

@javiercn, we're seeing new StaticWebAssets failures in this PR:

.dotnet/sdk/10.0.100-preview.4.25174.4/Sdks/Microsoft.NET.Sdk.StaticWebAssets/targets/Microsoft.NET.Sdk.StaticWebAssets.JSModules.targets(423,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "DefineStaticWebAssets" task failed unexpectedly.
System.ArgumentException: An item with the same key has already been added. Key: aWepj4Z1z9/lTzq2019OygffcVfW4IJp2WQch4iItHw=
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at Microsoft.AspNetCore.StaticWebAssets.Tasks.Utils.HashingUtils.ComputeHashLookup(MemoryStream memoryStream, ITaskItem[] candidateAssets, Span`1 metadata)
   at Microsoft.AspNetCore.StaticWebAssets.Tasks.DefineStaticWebAssets.GetOrCreateAssetsCache()
   at Microsoft.AspNetCore.StaticWebAssets.Tasks.DefineStaticWebAssets.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

It looks like we're seeing duplicate assets here:
https://github.com/dotnet/sdk/blob/3a3a0b50dfea869f3c22adcc9e8e40de12c0f6be/src/StaticWebAssetsSdk/Tasks/Utils/HashingUtils.cs#L63

Maybe we adjust this logic to:

  • Check if there's already an asset with the computed hash
  • If so, throw if the existing asset does not match the current one (to make sure there isn't a hash collision or some other bug in computing the hash)
  • Add the entry to the dictionary if it doesn't already exist

?

@javiercn
Copy link
Member

@MackinnonBuck I'm checking this.

There might be an issue here where some asset is duplicated for some reason (which shouldn't be)

@javiercn
Copy link
Member

As I suspected, there's a duplicate

image

This has caused issues in the past. I can fix it here, but I'm going to fix it on the SDK instead to make this more resilient.

@javiercn
Copy link
Member

dotnet/sdk#47940

Update version to 10.0.100-preview.4.25177.9
@javiercn
Copy link
Member

Pending on dotnet/sdk#47949, I forgot to put the same condition on None items

10.0.100-preview.4.25177.17
@javiercn javiercn merged commit eba9215 into main Mar 28, 2025
27 checks passed
@javiercn javiercn deleted the update-dotnet-sdk-10.0.100-preview.4.25174.4 branch March 28, 2025 06:17
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants