Skip to content

Ensure project.assets.json files are unique for SiteExtensions in VMR #61270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

Ensure project.assets.json files are unique for SiteExtensions in VMR #61270

merged 3 commits into from
Apr 10, 2025

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 1, 2025 •
edited
Loading

Should fix errors like:

D:\a\_work\1\s\.dotnet\sdk\10.0.100-preview.4.25177.22\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1047: Assets file 'D:\a\_work\1\s\src\aspnetcore\artifacts\obj\Microsoft.AspNetCore.Runtime.SiteExtension\project.assets.json' doesn't have a target for 'net462/win-x86'. Ensure that restore has run and that you have included 'net462' in the TargetFrameworks for your project. You may also need to include 'win-x86' in your project's RuntimeIdentifiers. [D:\a\_work\1\s\src\aspnetcore\src\SiteExtensions\Runtime\Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj]

https://dev.azure.com/dnceng/internal/_build/results?buildId=2683453&view=results

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 1, 2025
@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 1, 2025

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2677026&view=results

@wtgodbe wtgodbe requested a review from a team April 1, 2025 23:10
@build-analysis build-analysis bot mentioned this pull request Apr 2, 2025
Open
3 tasks
@wtgodbe wtgodbe marked this pull request as draft April 2, 2025 15:21
@wtgodbe wtgodbe marked this pull request as ready for review April 10, 2025 00:51
@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 10, 2025

Fixes #61371

@build-analysis build-analysis bot mentioned this pull request Apr 10, 2025
Open
@build-analysis build-analysis bot mentioned this pull request Apr 10, 2025
Open
3 tasks
@wtgodbe wtgodbe merged commit c31f60c into main Apr 10, 2025
27 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/DBPSiteEx branch April 10, 2025 21:36
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Apr 10, 2025
@mmitche mmitche mentioned this pull request Apr 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
10.0-preview4
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @akoeplinger @ViktorHofer