Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 13, 2025

This pull request updates the versioning and configuration for the Microsoft.Extensions.Identity.Stores package and related ASP.NET Core components. The most important changes include updating the baseline package version, modifying the patch configuration, and incrementing the patch version in the version properties.

Version Updates:

  • eng/Baseline.Designer.props: Updated the BaselinePackageVersion for Microsoft.Extensions.Identity.Stores from 2.3.0 to 2.3.2.
  • eng/Baseline.xml: Updated the package version for Microsoft.Extensions.Identity.Stores from 2.3.0 to 2.3.2 in the baseline configuration.

Patch Configuration:

  • eng/PatchConfig.props: Added a new conditional PropertyGroup for VersionPrefix 2.3.3, preparing for potential future patches.

Version Properties:

  • version.props: Incremented the AspNetCorePatchVersion from 2 to 3, reflecting the new patch level for ASP.NET Core.

@wtgodbe wtgodbe requested a review from Copilot May 13, 2025 22:00
@wtgodbe wtgodbe requested a review from a team as a code owner May 13, 2025 22:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the versioning and configuration for the Microsoft.Extensions.Identity.Stores package and related ASP.NET Core components.

  • Updated package versions in eng/Baseline.xml and eng/Baseline.Designer.props from 2.3.0 to 2.3.2.
  • Incremented AspNetCorePatchVersion in version.props from 2 to 3.
  • Introduced a new PropertyGroup in eng/PatchConfig.props for VersionPrefix 2.3.3 to support future patching.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
version.props Incremented AspNetCorePatchVersion to reflect the updated patch
eng/PatchConfig.props Added new conditional PropertyGroup for future patch configuration
eng/Baseline.xml Updated Microsoft.Extensions.Identity.Stores version to 2.3.2
eng/Baseline.Designer.props Updated BaselinePackageVersion for Identity.Stores to 2.3.2

</PackagesInPatch>
</PropertyGroup>
<PropertyGroup Condition=" '$(VersionPrefix)' == '2.3.3' ">
<PackagesInPatch>
Copy link

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding an inline comment within the empty tag to clarify that it is intentionally left empty for future packages.

Copilot uses AI. Check for mistakes.
@wtgodbe wtgodbe merged commit 58a29e7 into release/2.3 May 13, 2025
2 of 4 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/233 branch May 13, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants