Skip to content

[Blazor] Always treat "preloads" as new elements when doing enhanced navigation #63239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025
Merged

[Blazor] Always treat "preloads" as new elements when doing enhanced navigation #63239

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0911b4
wip
maraf Aug 13, 2025
7efce5d
Update DomSync.ts
maraf Aug 13, 2025
3a5550b
Update DomSync.ts
maraf Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Components/Web.JS/src/Rendering/DomMerging/DomSync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,11 @@ function domNodeComparer(a: Node, b: Node): UpdateCost {
return UpdateCost.Infinite;
}

// Always treat "preloads" as new elements.
if (isPreloadElement(a as Element) || isPreloadElement(b as Element)) {
return UpdateCost.Infinite;
}

return UpdateCost.None;
case Node.DOCUMENT_TYPE_NODE:
// It's invalid to insert or delete doctype, and we have no use case for doing that. So just skip such
Expand All @@ -319,6 +324,10 @@ function domNodeComparer(a: Node, b: Node): UpdateCost {
}
}

function isPreloadElement(el: Element): boolean {
return el.tagName === 'LINK' && el.attributes.getNamedItem('rel')?.value === 'preload';
}

function upgradeComponentCommentsToLogicalRootComments(root: Node): ComponentDescriptor[] {
const serverDescriptors = discoverComponents(root, 'server') as ServerComponentDescriptor[];
const webAssemblyDescriptors = discoverComponents(root, 'webassembly') as WebAssemblyComponentDescriptor[];
Expand Down
Loading