-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/10.0] Run entire E2E test with consistent enhanced navigation suppression setting #63527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
39
commits into
release/10.0
Choose a base branch
from
backport/pr-63132-to-release/10.0
base: release/10.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that don't support session storage at the same time. Allow single tests to request id assignment.
…ean it after each test.
…n the index page.
…rease timeouts for landing page assert that can be too short once in every 20 runs.
… inheritance to ServerTestBase, so that it calls ID granting method as well.
…ems locally because it runs in a small window).
wtgodbe
approved these changes
Sep 5, 2025
Is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-blazor
Includes: Blazor, Razor Components
tell-mode
Indicates a PR which is being merged during tell-mode
test-fixed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #63132 to release/10.0
/cc @ilonatommy
Run entire E2E test with consistent enhanced navigation suppression setting
Enhanced navigation suppression was per page, after navigating away we were falling back to enhanced navigation, regardless of the test settings. It's because we were treating the storage as temporary measure where we were setting the suppression flag and instantly removing it after reading it in blazor start function. For tests that never navigated away (did not re-trigger blazor boot function) it was enough but for other ones, not.
Description
EnhancedNavigationTestUtil.SuppressEnhancedNavigation
, they will get an exception like:SuppressEnhancedNavigation
appends to the exception message an instruction how to fix this situation.sessionStorage
, we have to have access to it. It's accessible only on loaded pages, so we chose the index page as the secure place for conducting the cleanup. To assure we're at the correct location we're checking for "session-storage-anchor" tag, adding it to test projects.Fixes #60875
Customer Impact
No impact, this is tests only.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
Just tests improvements.
Verification
Packaging changes reviewed?