Skip to content

[release/10.0] Fix SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscarded flake #63538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

[release/10.0] Fix SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscarded flake #63538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Components/Server/test/Circuits/RevalidatingServerAuthenticationStateProviderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ public async Task StopsRevalidatingAfterDisposal()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/60472")]
public async Task SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscarded()
{
// Arrange
Expand Down Expand Up @@ -174,9 +173,11 @@ public async Task SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBein
Assert.Equal("different user", (await provider.GetAuthenticationStateAsync()).User.Identity.Name);

// Subsequent revalidation can complete successfully
// We are checking all new logs because the revalidation loop iteration
// may happen multiple times (this made the test flaky in the past)
await provider.NextValidateAuthenticationStateAsyncCall;
Assert.Collection(provider.RevalidationCallLog.Skip(1),
call => Assert.Equal("different user", call.AuthenticationState.User.Identity.Name));
Assert.All(provider.RevalidationCallLog.Skip(1),
call => Assert.Equal("different user", call.AuthenticationState.User.Identity.Name));
}

[Fact]
Expand Down
Loading