[release/8.0] Use wait assert in flaky tests #63565

ilonatommy · 2025-09-05T15:51:03Z

Backport of Unquarantine RadioButtonGetsResetAfterSubmittingEnhancedForm #63556

It was done to main branch as well. The pass rate without this PR is 20%. This PR checks if just backporting the assert fix is enough or was there a bigger framework fix between ne9 and ne8. After 6 runs the failure was not reproduced. If it's not fully fixed then at least it significantly improved the pass rate.

Fixes [release/net8] Quarantine NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWebAssembly( #61143.

It used to have 0% pass rate before this PR. With the fix, it did not fail yet.

Quarantine test that fails on every run and is not related to the changes in this PR: [release/8.0] Quarantine CanSendAndReceiveUserMessagesUserNameWithPatternIsTreatedAsLiteral #63582.

ilonatommy · 2025-09-08T06:23:05Z

1st attempt: it did not fail but we are hitting #61143, that might get fixed by #63564. In the meantime, rerunning.

ilonatommy · 2025-09-08T07:45:48Z

2nd attempt: fine but NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWebAssembly is still failing and at the same time, RadioButtonGetsResetAfterSubmittingEnhancedForm is failing on the PR that tries to fix NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWebAssembly. I will merge both fixes and run them a bit few more times on the same CI.

…erAndWebAssembly`

ilonatommy · 2025-09-08T09:10:02Z

/azp run

(3rd attempt: fine)

azure-pipelines · 2025-09-08T09:10:22Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull Request Overview

This PR backports a fix for flaky end-to-end tests by replacing immediate Assert calls with WaitAssert and Browser.True() methods to handle timing issues in web UI interactions. The changes specifically target tests that were experiencing low pass rates (20% and 0%) due to race conditions between UI state changes and assertions.

Key changes:

Replace immediate assertions with wait-based assertions in form handling tests
Update navigation tests to use browser-specific assertion methods with proper timing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
FormWithParentBindingContextTest.cs	Converts Assert.True/False calls to WaitAssert.True/False for radio button and checkbox state verification
EnhancedNavigationTest.cs	Replaces Assert.EndsWith with Browser.True() for URI validation with proper wait handling

ilonatommy · 2025-09-08T10:31:14Z

/azp run

azure-pipelines · 2025-09-08T10:31:32Z

Azure Pipelines successfully started running 3 pipeline(s).

ilonatommy · 2025-09-08T10:42:58Z

Not related tests in aspnetcore-ci are failing consequently with #63582.

Updated [Microsoft.AspNetCore.Identity.UI](https://github.com/dotnet/aspnetcore) from 8.0.20 to 8.0.21. <details> <summary>Release notes</summary> _Sourced from [Microsoft.AspNetCore.Identity.UI's releases](https://github.com/dotnet/aspnetcore/releases)._ ## 8.0.21 [Release](https://github.com/dotnet/core/releases/tag/v8.0.21) ## What's Changed * Update branding to 8.0.21 by @vseanreesermsft in dotnet/aspnetcore#63509 * [release/8.0] (deps): Bump src/submodules/googletest from `373af2e` to `eb2d85e` by @dependabot[bot] in dotnet/aspnetcore#63500 * [release/8.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key by @github-actions[bot] in dotnet/aspnetcore#63250 * [release/8.0] Extend Unofficial 1ES template in IdentityModel nightly tests job by @github-actions[bot] in dotnet/aspnetcore#63466 * [release/8.0] Quarantine ResponseBody_WriteContentLength_PassedThrough by @github-actions[bot] in dotnet/aspnetcore#63534 * [release/8.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro[bot] in dotnet/aspnetcore#63261 * [release/8.0] Use wait assert in flaky tests by @ilonatommy in dotnet/aspnetcore#63565 * [release/8.0] Update Microsoft.Build versions by @github-actions[bot] in dotnet/aspnetcore#62507 * Merging internal commits for release/8.0 by @vseanreesermsft in dotnet/aspnetcore#63603 * backport(8.0): Fix runtime architecture detection logic in ANCM by @DeagleGross in dotnet/aspnetcore#63706 **Full Changelog**: dotnet/aspnetcore@v8.0.20...v8.0.21 Commits viewable in [compare view](dotnet/aspnetcore@v8.0.20...v8.0.21). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.AspNetCore.Identity.UI&package-manager=nuget&previous-version=8.0.20&new-version=8.0.21)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… 8.0.21 (#620) Updated [Microsoft.AspNetCore.Authentication.OpenIdConnect](https://github.com/dotnet/aspnetcore) from 8.0.20 to 8.0.21. <details> <summary>Release notes</summary> _Sourced from [Microsoft.AspNetCore.Authentication.OpenIdConnect's releases](https://github.com/dotnet/aspnetcore/releases)._ ## 8.0.21 [Release](https://github.com/dotnet/core/releases/tag/v8.0.21) ## What's Changed * Update branding to 8.0.21 by @vseanreesermsft in dotnet/aspnetcore#63509 * [release/8.0] (deps): Bump src/submodules/googletest from `373af2e` to `eb2d85e` by @dependabot[bot] in dotnet/aspnetcore#63500 * [release/8.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key by @github-actions[bot] in dotnet/aspnetcore#63250 * [release/8.0] Extend Unofficial 1ES template in IdentityModel nightly tests job by @github-actions[bot] in dotnet/aspnetcore#63466 * [release/8.0] Quarantine ResponseBody_WriteContentLength_PassedThrough by @github-actions[bot] in dotnet/aspnetcore#63534 * [release/8.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro[bot] in dotnet/aspnetcore#63261 * [release/8.0] Use wait assert in flaky tests by @ilonatommy in dotnet/aspnetcore#63565 * [release/8.0] Update Microsoft.Build versions by @github-actions[bot] in dotnet/aspnetcore#62507 * Merging internal commits for release/8.0 by @vseanreesermsft in dotnet/aspnetcore#63603 * backport(8.0): Fix runtime architecture detection logic in ANCM by @DeagleGross in dotnet/aspnetcore#63706 **Full Changelog**: dotnet/aspnetcore@v8.0.20...v8.0.21 Commits viewable in [compare view](dotnet/aspnetcore@v8.0.20...v8.0.21). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.AspNetCore.Authentication.OpenIdConnect&package-manager=nuget&previous-version=8.0.20&new-version=8.0.21)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Green <84688932+michael-j-green@users.noreply.github.com>

… to 8.0.21 (#619) Updated [Microsoft.AspNetCore.Authentication.MicrosoftAccount](https://github.com/dotnet/aspnetcore) from 8.0.20 to 8.0.21. <details> <summary>Release notes</summary> _Sourced from [Microsoft.AspNetCore.Authentication.MicrosoftAccount's releases](https://github.com/dotnet/aspnetcore/releases)._ ## 8.0.21 [Release](https://github.com/dotnet/core/releases/tag/v8.0.21) ## What's Changed * Update branding to 8.0.21 by @vseanreesermsft in dotnet/aspnetcore#63509 * [release/8.0] (deps): Bump src/submodules/googletest from `373af2e` to `eb2d85e` by @dependabot[bot] in dotnet/aspnetcore#63500 * [release/8.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key by @github-actions[bot] in dotnet/aspnetcore#63250 * [release/8.0] Extend Unofficial 1ES template in IdentityModel nightly tests job by @github-actions[bot] in dotnet/aspnetcore#63466 * [release/8.0] Quarantine ResponseBody_WriteContentLength_PassedThrough by @github-actions[bot] in dotnet/aspnetcore#63534 * [release/8.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro[bot] in dotnet/aspnetcore#63261 * [release/8.0] Use wait assert in flaky tests by @ilonatommy in dotnet/aspnetcore#63565 * [release/8.0] Update Microsoft.Build versions by @github-actions[bot] in dotnet/aspnetcore#62507 * Merging internal commits for release/8.0 by @vseanreesermsft in dotnet/aspnetcore#63603 * backport(8.0): Fix runtime architecture detection logic in ANCM by @DeagleGross in dotnet/aspnetcore#63706 **Full Changelog**: dotnet/aspnetcore@v8.0.20...v8.0.21 Commits viewable in [compare view](dotnet/aspnetcore@v8.0.20...v8.0.21). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.AspNetCore.Authentication.MicrosoftAccount&package-manager=nuget&previous-version=8.0.20&new-version=8.0.21)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…#618) Updated [Microsoft.AspNetCore.Authentication.Google](https://github.com/dotnet/aspnetcore) from 8.0.20 to 8.0.21. <details> <summary>Release notes</summary> _Sourced from [Microsoft.AspNetCore.Authentication.Google's releases](https://github.com/dotnet/aspnetcore/releases)._ ## 8.0.21 [Release](https://github.com/dotnet/core/releases/tag/v8.0.21) ## What's Changed * Update branding to 8.0.21 by @vseanreesermsft in dotnet/aspnetcore#63509 * [release/8.0] (deps): Bump src/submodules/googletest from `373af2e` to `eb2d85e` by @dependabot[bot] in dotnet/aspnetcore#63500 * [release/8.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key by @github-actions[bot] in dotnet/aspnetcore#63250 * [release/8.0] Extend Unofficial 1ES template in IdentityModel nightly tests job by @github-actions[bot] in dotnet/aspnetcore#63466 * [release/8.0] Quarantine ResponseBody_WriteContentLength_PassedThrough by @github-actions[bot] in dotnet/aspnetcore#63534 * [release/8.0] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro[bot] in dotnet/aspnetcore#63261 * [release/8.0] Use wait assert in flaky tests by @ilonatommy in dotnet/aspnetcore#63565 * [release/8.0] Update Microsoft.Build versions by @github-actions[bot] in dotnet/aspnetcore#62507 * Merging internal commits for release/8.0 by @vseanreesermsft in dotnet/aspnetcore#63603 * backport(8.0): Fix runtime architecture detection logic in ANCM by @DeagleGross in dotnet/aspnetcore#63706 **Full Changelog**: dotnet/aspnetcore@v8.0.20...v8.0.21 Commits viewable in [compare view](dotnet/aspnetcore@v8.0.20...v8.0.21). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.AspNetCore.Authentication.Google&package-manager=nuget&previous-version=8.0.20&new-version=8.0.21)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Make the flaky test wait for the conditon to be true.

32257ad

dotnet-policy-service bot added this to the 8.0.x milestone Sep 5, 2025

ilonatommy changed the title ~~Make the flaky test wait for the conditon to be true.~~ Use wait assert in flaky RadioButtonGetsResetAfterSubmittingEnhancedForm Sep 5, 2025

Improve `NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServ…

a4f5875

…erAndWebAssembly`

ilonatommy mentioned this pull request Sep 8, 2025

Test NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWebAssembly #63564

Closed

dotnet deleted a comment from azure-pipelines bot Sep 8, 2025

ilonatommy marked this pull request as ready for review September 8, 2025 10:04

Copilot AI review requested due to automatic review settings September 8, 2025 10:04

ilonatommy requested a review from a team as a code owner September 8, 2025 10:04

Copilot AI reviewed Sep 8, 2025

View reviewed changes

ilonatommy added the area-blazor Includes: Blazor, Razor Components label Sep 8, 2025

ilonatommy self-assigned this Sep 8, 2025

ilonatommy requested review from javiercn, oroztocil and wtgodbe September 8, 2025 10:08

ilonatommy added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 8, 2025

ilonatommy changed the title ~~Use wait assert in flaky RadioButtonGetsResetAfterSubmittingEnhancedForm~~ [release/8.0] Use wait assert in flaky RadioButtonGetsResetAfterSubmittingEnhancedForm Sep 8, 2025

akoeplinger approved these changes Sep 8, 2025

View reviewed changes

Add quarantine to the failing test.

64911af

ilonatommy requested review from BrennanConroy and halter73 as code owners September 8, 2025 11:27

ilonatommy changed the title ~~[release/8.0] Use wait assert in flaky RadioButtonGetsResetAfterSubmittingEnhancedForm~~ [release/8.0] Use wait assert in flaky tests Sep 8, 2025

wtgodbe approved these changes Sep 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release/8.0] Use wait assert in flaky tests #63565

[release/8.0] Use wait assert in flaky tests #63565

Uh oh!

ilonatommy commented Sep 5, 2025 •

edited

Loading

Uh oh!

ilonatommy commented Sep 8, 2025

Uh oh!

ilonatommy commented Sep 8, 2025 •

edited

Loading

Uh oh!

ilonatommy commented Sep 8, 2025 •

edited

Loading

Uh oh!

azure-pipelines bot commented Sep 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

ilonatommy commented Sep 8, 2025

Uh oh!

azure-pipelines bot commented Sep 8, 2025

Uh oh!

ilonatommy commented Sep 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[release/8.0] Use wait assert in flaky tests #63565

[release/8.0] Use wait assert in flaky tests #63565

Uh oh!

Conversation

ilonatommy commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ilonatommy commented Sep 8, 2025

Uh oh!

ilonatommy commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ilonatommy commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Sep 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

ilonatommy commented Sep 8, 2025

Uh oh!

azure-pipelines bot commented Sep 8, 2025

Uh oh!

ilonatommy commented Sep 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ilonatommy commented Sep 5, 2025 •

edited

Loading

ilonatommy commented Sep 8, 2025 •

edited

Loading

ilonatommy commented Sep 8, 2025 •

edited

Loading