Skip to content

Add FrameworkReference to Microsoft.Aspnetcore.App for non-SharedFx projects with SharedFx-only references #65478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 16 commits into from
Feb 27, 2026
+33 −0
Merged

Add FrameworkReference to Microsoft.Aspnetcore.App for non-SharedFx projects with SharedFx-only references #65478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d4b02b5
Add FrameworkReference for non-SharedFx projects with SharedFx refs
wtgodbe Feb 19, 2026
7a69f74
Better approach
wtgodbe Feb 20, 2026
93514a7
Apply suggestions from code review
wtgodbe Feb 20, 2026
3768760
Remove Transitive ref
wtgodbe Feb 24, 2026
c90074d
Merge remote-tracking branch 'upstream/wtgodbe/VibeIt' into wtgodbe/V…
wtgodbe Feb 24, 2026
241f81e
fixup
wtgodbe Feb 24, 2026
514ae40
Just to be sure
wtgodbe Feb 24, 2026
5076157
Feedback
wtgodbe Feb 24, 2026
c642e6b
Fixup
wtgodbe Feb 25, 2026
d9bdb05
Revert "Fixup"
wtgodbe Feb 25, 2026
1232509
Revert "Feedback"
wtgodbe Feb 25, 2026
d180f8a
Fixup
wtgodbe Feb 25, 2026
6eeb497
Revert "Fixup"
wtgodbe Feb 25, 2026
fbd36d5
Test
wtgodbe Feb 25, 2026
5d85a2b
Get error
wtgodbe Feb 26, 2026
79ec500
Fixup
wtgodbe Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@
</PropertyGroup>

<ItemGroup>
<_RemovedAspNetKnownFrameworkReference Include="@(KnownFrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App'))" />
Copy link
Member

@ericstj ericstj Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than removing this and adding it back did you consolidating the logic?

<KnownFrameworkReference Condition="'$(UseAspNetCoreSharedRuntime)' != 'true'" Remove="Microsoft.AspNetCore.App" />
<KnownFrameworkReference Remove="Microsoft.WindowsDesktop.App" />
</ItemGroup>
Expand Down
32 changes: 32 additions & 0 deletions eng/targets/ResolveReferences.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,38 @@
Text="Redundant &lt;FrameworkReference&gt;. If you have an explicit item in the project file, you might be able to remove it. Some SDKs, like Microsoft.NET.Sdk.Web, add this implicitly." />
</Target>

<!--
NuGet pack reads framework references from restore assets. For affected SDK-pack projects, add a temporary
framework reference during project evaluation so that it flows into the restore assets used by pack / GenerateNuspec.
-->

<ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)' AND
'$(IsPackable)' == 'true' AND
'$(IsAspNetCoreApp)' != 'true' AND
'@(_FrameworkProjectReference)' != '' AND
'@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' == '0'">
<KnownFrameworkReference Include="@(_RemovedAspNetKnownFrameworkReference)" />
<!-- Mark as IsTransitiveFrameworkReference to exclude the pruning data: https://github.com/dotnet/sdk/issues/53106 -->
<FrameworkReference Include="Microsoft.AspNetCore.App" IsTransitiveFrameworkReference="true" DoNotResolve="true" />
</ItemGroup>

<!-- Remove the referenced AspNetCore framework before it's resolved in ResolveFrameworkReferences. This lets us use our own references. -->
<Target Name="_RemoveAspNetCoreFrameworkReference"
BeforeTargets="ResolveFrameworkReferences" >
<ItemGroup>
<FrameworkReference Remove="@(FrameworkReference->WithMetadataValue('DoNotResolve', 'true'))" />
</ItemGroup>
</Target>

<!-- Remove Transtive Microsoft.Aspnetcore.App FrameworkReference, for projects referencing the affected projects above -->
<Target Name="_RemoveAspNetCoreTransitiveFrameworkReference"
BeforeTargets="AddTransitiveFrameworkReferences"
Condition="'$(UseAspNetCoreSharedRuntime)' != 'true'" >
<ItemGroup>
<TransitiveFrameworkReference Remove="Microsoft.AspNetCore.App" />
</ItemGroup>
</Target>

<!--
This target resolves remaining Reference items to Packages, if possible. If not, they are left as Reference
items for the SDK to resolve. This executes on NuGet restore and during DesignTimeBuild. It should not run in
Expand Down
Loading