Update dependencies with darc #6714

natemcmaster · 2019-01-15T18:55:28Z

Manually ran darc update-dependencies -c '.NET Core 3 Dev'.

It missed:

Updating DotNetEfPackageVersion, even though versions.details.xml was updated (cc @mmitche )
Updating dependencies from aspnetcore-tooling (cc @pranavkm @rynowak )

* Use Razor SDK version with workaround for dotnet#6500 * Remove package reference to Razor SDK in template

src/Components/src/Microsoft.AspNetCore.Components.Build/targets/RazorCompilation.targets

benaadams · 2019-01-15T21:34:31Z

Middleware\HealthChecks.EntityFrameworkCore\src\
 DependencyInjection\EntityFrameworkCoreHealthChecksBuilderExtensions.cs(44,24): 

error CS1574: XML comment has cref attribute 'IDatabaseCreatorWithCanConnect'
 that could not be resolved 

[F:\vsagent\11\s\src\Middleware\HealthChecks.EntityFrameworkCore\src\Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.csproj]

natemcmaster · 2019-01-15T22:24:07Z

Sent email to figure out where that API went.

benaadams · 2019-01-16T01:55:13Z

System.Net.Http.HttpRequestException : Error while copying content to a stream.
---- System.IO.IOException : 
-------- System.TypeLoadException : Could not load type 'System.Buffers.OperationStatus'
 from assembly 'System.Memory, Version=4.2.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.

Guessing you need a new runtime? dotnet/coreclr#21912

/cc @GrabYourPitchforks

natemcmaster · 2019-01-16T02:14:03Z

Progress:

Updates from AspNetCore-Tooling are working now.
DotnetEfPackageVersion is still skipped.
The bot isn't opening PRs due to MAX_PATH (which should be addressed by Convert Components projects to use ProjectRef #6698)

natemcmaster · 2019-01-16T02:15:01Z

@benaadams I ran update again to get the latest netcore.app. If the problem persists, then this will likely need to be sent to corefx/coreclr as a partner-blocking issues.

benaadams · 2019-01-16T02:37:41Z

Different one this time

 error : Missing Version metadata for the following external dependencies:
 error :  - Microsoft.JSInterop. 

2019-01-16T02:21:11.1735260Z F:\vsagent\8\s\build\repo.targets(270,5):
  [F:\vsagent\8\.dotnet\buildtools\korebuild\3.0.0-build-20190110.4\KoreBuild.proj]
2019-01-16T02:21:11.1735472Z F:\vsagent\8\s\build\repo.targets(270,5): 
 [F:\vsagent\8\.dotnet\buildtools\korebuild\3.0.0-build-20190110.4\KoreBuild.proj]

benaadams · 2019-01-16T03:25:12Z

Build and test: ANCM IIS Job

2019-01-16T02:40:46.4592825Z Current agent version: '2.144.0'
2019-01-16T02:40:46.4837499Z Prepare build directory.
2019-01-16T02:40:47.1261315Z ##[error]One or more errors occurred.
 (One or more errors occurred.
 (Access to the path 'F:\vsagent\2\s\
  src\Servers\Kestrel\test\Interop.FunctionalTests\bin\Release
  \netcoreapp3.0\h2spec\windows\h2spec.exe' is denied.)) 
  (Access to the path 'F:\vsagent\2\s\src\Servers\Kestrel\test\Interop.FunctionalTests\bin\Release
  \netcoreapp3.0\h2spec\windows\h2spec.exe' is denied.)
2019-01-16T02:40:47.1292725Z ##[section]Finishing: Initialize job

benaadams · 2019-01-16T03:29:41Z

  [xUnit.net 00:11:21.21]     E2ETests.SmokeTests.Smoke_Tests(variant: Server: IISExpress, TFM: netcoreapp3.0, Type: Standalone, Arch: x64, ANCM: V2, Host: InProcess) [FAIL]
Failed   E2ETests.SmokeTests.Smoke_Tests(variant: Server: IISExpress, TFM: netcoreapp3.0, Type: Standalone, Arch: x64, ANCM: V2, Host: InProcess)
Error Message:
 Assert.Contains() Failure
Not found: <h2>Checkout Complete</h2>
In value:  <!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Address And Payment - ASP.NET MVC Music Store</title>

    
Stack Trace:
   at E2ETests.Validator.CheckOutCartItems() in /_/src/MusicStore/test/MusicStore.E2ETests/Implementation/Validator.cs:line 509
   at E2ETests.SmokeTests.RunTestsAsync(DeploymentResult deploymentResult, ILogger logger) in /_/src/MusicStore/test/MusicStore.E2ETests/SmokeTests.cs:line 142
   at E2ETests.SmokeTests.Smoke_Tests(TestVariant variant) in /_/src/MusicStore/test/MusicStore.E2ETests/SmokeTests.cs:line 56
--- End of stack trace from previous location where exception was thrown ---

019-01-16T03:25:00.1466173Z F:\vsagent\7\.dotnet\buildtools\korebuild\
 3.0.0-build-20190110.4\modules\vstest\module.targets(136,5):

 error : Test group MusicStore.E2ETests/netcoreapp3.0 failed with exit code '1'. [F:\vsagent\7\.dotnet\buildtools\korebuild\3.0.0-build-20190110.4\KoreBuild.proj]

natemcmaster · 2019-01-16T18:22:51Z

The test failures are consistent, not just flaky. @ajcvickers were there any recent changes in EF Core which might lead to this error?

Microsoft.EntityFrameworkCore.Database.Command[20102]
      Failed executing DbCommand (19ms) [Parameters=[@p0='?' (DbType = Int32), @p1='?' (DbType = Int32), @p2='?' (DbType = Int32), @p3='?' (DbType = Decimal)], CommandType='Text', CommandTimeout='30']
      SET NOCOUNT ON;
      INSERT INTO [OrderDetails] ([AlbumId], [OrderId], [Quantity], [UnitPrice])
      VALUES (@p0, @p1, @p2, @p3);
      SELECT [OrderDetailId]
      FROM [OrderDetails]
      WHERE @@ROWCOUNT = 1 AND [OrderDetailId] = scope_identity();
System.Data.SqlClient.SqlException (0x80131904): The INSERT statement conflicted with the FOREIGN KEY constraint "FK_OrderDetails_Orders_OrderId". The conflict occurred in database "MusicStore", table "dbo.Orders", column 'OrderId'.
The statement has been terminated.
   at System.Data.SqlClient.SqlCommand.<>c.<ExecuteDbDataReaderAsync>b__126_0(Task`1 result)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteAsync(IRelationalConnection connection, DbCommandMethod executeMethod, IReadOnlyDictionary`2 parameterValues, CancellationToken cancellationToken) in /_/src/EFCore.Relational/Storage/Internal/RelationalCommand.cs:line 340

natemcmaster · 2019-01-17T00:44:30Z

Build failures this time due to dotnet/arcade#1677. The version of core-setup hasn't caught up with the version of corefx packages.

benaadams · 2019-01-17T01:41:08Z

Failure is unexpected assemblies

Starting test execution, please wait...
[xUnit.net 00:00:00.33]     Microsoft.AspNetCore.SharedFxTests.PlatformManifestListsAllFiles [FAIL]
Failed   Microsoft.AspNetCore.SharedFxTests.PlatformManifestListsAllFiles
Error Message:
 Assert.Empty() Failure
Collection: ["Microsoft.Win32.Registry", "System.Diagnostics.DiagnosticSource", "System.Reflection.Metadata", "System.Security.AccessControl", "System.Security.Cryptography.Cng", ...]
Stack Trace:
   at Microsoft.AspNetCore.SharedFxTests.PlatformManifestListsAllFiles() in /_/src/Framework/test/SharedFxTests.cs:line 72
Standard Output Messages:
 ==== file contents ====
...
*snip*

 ==== unexpected assemblies in the manifest ====
 Microsoft.Win32.Registry
System.Diagnostics.DiagnosticSource
System.Reflection.Metadata
System.Security.AccessControl
System.Security.Cryptography.Cng
System.Security.Principal.Windows


Results File: F:\vsagent\2\s\artifacts\logs\SharedFx-UnitTests-3.0.0-preview-19066-79.trx

Total tests: 4. Passed: 3. Failed: 1. Skipped: 0.
Test Run Failed.
Test execution time: 1.2700 Seconds
\vsagent\2\s\build\SharedFx.targets(104,5):
 error : SharedFx.UnitTests failed with exit code '1'. [F:\vsagent\2\.dotnet\buildtools\korebuild\3.0.0-build-20190110.4\KoreBuild.proj]

Build FAILED.

natemcmaster · 2019-01-17T15:30:12Z

@benaadams - yes, this is the 'diamond dependency' problem I described in dotnet/arcade#1677. We don't have a good mechanism yet for telling Arcade that we can't take a version of corefx higher than what core-setup used. Until we have a fix for this, our dependency flow is going to take a lot of trial and error to get the right combination of versions.

natemcmaster · 2019-01-17T15:32:41Z

Waiting on dotnet/core-setup#4996. cc @dagood

natemcmaster · 2019-01-17T20:35:28Z

Test failures in Linux now.

2019-01-17T20:30:24.4873203Z   System.InvalidOperationException: No process is associated with this object.
2019-01-17T20:30:24.4873972Z      at System.Diagnostics.Process.EnsureState(State state)
2019-01-17T20:30:24.4874675Z      at System.Diagnostics.Process.EnsureState(State state)
2019-01-17T20:30:24.4875635Z      at System.Diagnostics.Process.GetWaitState()
2019-01-17T20:30:24.4876288Z      at System.Diagnostics.Process.WaitForExitCore(Int32 milliseconds)
2019-01-17T20:30:24.4876529Z      at System.Diagnostics.Process.WaitForExit()
2019-01-17T20:30:24.4876780Z      at Microsoft.AspNetCore.SignalR.StackExchangeRedis.Tests.Docker.RunProcessAndWait(String fileName, String arguments, String prefix, ILogger logger, TimeSpan timeout, String& output) in /_/src/SignalR/server/StackExchangeRedis/test/Docker.cs:line 163

https://dev.azure.com/dnceng/public/_build/results?buildId=75206&view=logs&jobId=7536d2cd-87d4-54fe-4891-bfbbf2741d83&taskId=125326b4-b8df-5c91-4ebb-8c86fdfefd4c&lineStart=10001&lineEnd=10011&colStart=1&colEnd=174

@muratg @BrennanConroy @mikaelm12 - does this problem look familiar?

mikaelm12 · 2019-01-17T20:38:16Z

Hmm, took a look at the build failure and I haven't seen that before

muratg · 2019-01-17T20:40:48Z

@mikaelm12 can you investigate the signalr issue please?

mikaelm12 · 2019-01-17T20:42:09Z

Yeah, will take a closer look

mikaelm12 · 2019-01-17T20:47:55Z

Discussed with Nate. We think this is a possible regression in the new .Net Core runtime. Reaching out to the appropriate people.

benaadams · 2019-01-17T20:48:08Z

Might want to check corefx for issues on WaitForExit, see if there is anything related e.g. https://github.com/dotnet/corefx/issues/31713

natemcmaster · 2019-01-17T20:51:41Z

@ajaybhargavb found a workaround for https://github.com/dotnet/corefx/issues/31713. See dotnet/razor@2ad0641#diff-fec826feae04e51c0d94076385408bdc

BrennanConroy · 2019-01-17T21:20:31Z

The redis stuff is a benign failure. Looks like the build failed because of some razor tests.

…

________________________________ From: Nate McMaster <notifications@github.com> Sent: Thursday, January 17, 2019 12:52:06 PM To: aspnet/AspNetCore Cc: Brennan Conroy; Mention Subject: Re: [aspnet/AspNetCore] Update dependencies with darc (#6714) @ajaybhargavb<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fajaybhargavb&data=02%7C01%7Cbrecon%40microsoft.com%7C34360fb418844e62d6b008d67cbda42d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833551280455857&sdata=nZwPp%2Bd%2Fz4SST2EsFnqmXHaObd2e1dV2JBtloXtFlbg%3D&reserved=0> found a workaround for dotnet/corefx#31713<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcorefx%2Fissues%2F31713&data=02%7C01%7Cbrecon%40microsoft.com%7C34360fb418844e62d6b008d67cbda42d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833551280465870&sdata=oxTRJVsAptcBloIXKb%2Bvv1ChWUIQyoPG%2FqSAPvn6%2FIE%3D&reserved=0>. See dotnet/razor@2ad0641#diff-fec826feae04e51c0d94076385408bdc<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FAspNetCore-Tooling%2Fcommit%2F2ad0641b1e8e0cebb17115e3b8a7eb878f460d5c%23diff-fec826feae04e51c0d94076385408bdc&data=02%7C01%7Cbrecon%40microsoft.com%7C34360fb418844e62d6b008d67cbda42d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833551280465870&sdata=UsYXQbZWPmlMA5D2ZHgtdyystx6NNd3LWSNkF%2FBb%2B2A%3D&reserved=0> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FAspNetCore%2Fpull%2F6714%23issuecomment-455327579&data=02%7C01%7Cbrecon%40microsoft.com%7C34360fb418844e62d6b008d67cbda42d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833551280475874&sdata=6JpmuLd6buNz0dQhWBpppFx5NbE2hYJHsyz9KLkiVbA%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHOVEV9_zH0vN2LUvhxsSCmu6xbt6tLTks5vEOJ2gaJpZM4aBl2K&data=02%7C01%7Cbrecon%40microsoft.com%7C34360fb418844e62d6b008d67cbda42d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636833551280485886&sdata=aVOsb8mgsuyX0lW6wzz%2Bcg%2FgHPfxUadCXLVB8WstBZM%3D&reserved=0>.

natemcmaster · 2019-01-17T21:23:59Z

@muratg @Eilon one test failure in what appears to be a flaky test. Sounds sufficiently good to me to override the PR check. Thoughts?

muratg · 2019-01-17T21:30:36Z

@natemcmaster, agreed.

tmds · 2019-02-21T14:07:33Z

2019-01-17T20:30:24.4873203Z   System.InvalidOperationException: No process is associated with this object.
2019-01-17T20:30:24.4873972Z      at System.Diagnostics.Process.EnsureState(State state)
2019-01-17T20:30:24.4874675Z      at System.Diagnostics.Process.EnsureState(State state)
2019-01-17T20:30:24.4875635Z      at System.Diagnostics.Process.GetWaitState()
2019-01-17T20:30:24.4876288Z      at System.Diagnostics.Process.WaitForExitCore(Int32 milliseconds)
2019-01-17T20:30:24.4876529Z      at System.Diagnostics.Process.WaitForExit()

@natemcmaster @benaadams this may help: you get this when you call WaitForExit after calling Stop/Dispose on a Process.

pranavkm and others added 2 commits January 15, 2019 10:44

Update Razor Sdk version

82941f9

* Use Razor SDK version with workaround for dotnet#6500 * Remove package reference to Razor SDK in template

Update dependencies with darc

69403f8

natemcmaster requested a review from dougbu January 15, 2019 18:55

Nate McMaster added 2 commits January 15, 2019 10:57

Manually update DotNetEfPackageVersion

03ef8e3

Merge branch 'prkrishn/update-versions' into update-deps

f74581c

dougbu reviewed Jan 15, 2019

View reviewed changes

src/Components/src/Microsoft.AspNetCore.Components.Build/targets/RazorCompilation.targets Outdated Show resolved Hide resolved

natemcmaster mentioned this pull request Jan 15, 2019

Add Components packages to shared fx #6722

Merged

Merge branch 'master' into update-deps

99da978

Run update dependencies again

efe616c

natemcmaster requested a review from SteveSandersonMS as a code owner January 15, 2019 22:26

React to breaking change

c043cd0

natemcmaster requested a review from Tratcher as a code owner January 15, 2019 22:44

Merge branch 'master' into update-deps

be7f058

natemcmaster added the blocked The work on this issue is blocked due to some dependency label Jan 16, 2019

Nate McMaster added 3 commits January 15, 2019 18:05

Merge branch 'master' into update-deps

8f5f110

Run update deps again

05ac0e0

Merge branch 'master' into update-deps

fa4ecab

natemcmaster changed the title ~~wip: Update dependencies with darc~~ Update dependencies with darc Jan 16, 2019

Re-add MicrosoftJSInteropPackageVersion

e753007

natemcmaster removed the blocked The work on this issue is blocked due to some dependency label Jan 16, 2019

Log error in music store test

27a16e0

Nate McMaster added 2 commits January 16, 2019 16:51

Update dependencies again

91d6222

Merge branch 'master' into update-deps

f4f6408

natemcmaster mentioned this pull request Jan 17, 2019

Update dependencies from aspnet/Extensions #6780

Closed

natemcmaster added the blocked The work on this issue is blocked due to some dependency label Jan 17, 2019

This was referenced Jan 17, 2019

Update dependencies from dotnet/core-setup #6785

Closed

Update dependencies from dotnet/corefx #6801

Closed

Update dependencies from aspnet/EntityFrameworkCore #6802

Closed

Merge branch 'master' into update-deps

ccdad62

natemcmaster mentioned this pull request Jan 17, 2019

Use JSInterop package that we produce from Extensions #6808

Merged

Nate McMaster added 2 commits January 17, 2019 12:01

Update netcore-app

cf5ca03

Merge branch 'master' into update-deps

397e071

natemcmaster removed the blocked The work on this issue is blocked due to some dependency label Jan 17, 2019

natemcmaster merged commit 090c53c into dotnet:master Jan 17, 2019

natemcmaster deleted the update-deps branch January 17, 2019 21:31

pakrym mentioned this pull request Mar 1, 2019

[master] Update dependencies from 5 repositories #8073

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies with darc #6714

Update dependencies with darc #6714

natemcmaster commented Jan 15, 2019

benaadams commented Jan 15, 2019

natemcmaster commented Jan 15, 2019

benaadams commented Jan 16, 2019 •

edited

Loading

natemcmaster commented Jan 16, 2019

natemcmaster commented Jan 16, 2019

benaadams commented Jan 16, 2019

benaadams commented Jan 16, 2019

benaadams commented Jan 16, 2019

natemcmaster commented Jan 16, 2019

natemcmaster commented Jan 17, 2019

benaadams commented Jan 17, 2019

natemcmaster commented Jan 17, 2019

natemcmaster commented Jan 17, 2019

natemcmaster commented Jan 17, 2019

mikaelm12 commented Jan 17, 2019

muratg commented Jan 17, 2019

mikaelm12 commented Jan 17, 2019

mikaelm12 commented Jan 17, 2019

benaadams commented Jan 17, 2019

natemcmaster commented Jan 17, 2019

BrennanConroy commented Jan 17, 2019 via email

natemcmaster commented Jan 17, 2019

muratg commented Jan 17, 2019

tmds commented Feb 21, 2019

Update dependencies with darc #6714

Update dependencies with darc #6714

Conversation

natemcmaster commented Jan 15, 2019

benaadams commented Jan 15, 2019

natemcmaster commented Jan 15, 2019

benaadams commented Jan 16, 2019 • edited Loading

natemcmaster commented Jan 16, 2019

natemcmaster commented Jan 16, 2019

benaadams commented Jan 16, 2019

benaadams commented Jan 16, 2019

benaadams commented Jan 16, 2019

natemcmaster commented Jan 16, 2019

natemcmaster commented Jan 17, 2019

benaadams commented Jan 17, 2019

natemcmaster commented Jan 17, 2019

natemcmaster commented Jan 17, 2019

natemcmaster commented Jan 17, 2019

mikaelm12 commented Jan 17, 2019

muratg commented Jan 17, 2019

mikaelm12 commented Jan 17, 2019

mikaelm12 commented Jan 17, 2019

benaadams commented Jan 17, 2019

natemcmaster commented Jan 17, 2019

BrennanConroy commented Jan 17, 2019 via email

natemcmaster commented Jan 17, 2019

muratg commented Jan 17, 2019

tmds commented Feb 21, 2019

benaadams commented Jan 16, 2019 •

edited

Loading