Enable strict mode in roslyn compiler #6950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Jan 23, 2019
| { | ||
| return Task.CompletedTask; | ||
| } | ||
|
|
There was a problem hiding this comment.
ValueProviderResult is a struct so result would always be false
There was a problem hiding this comment.
Custom == operator is not invoked here either.
There was a problem hiding this comment.
This is probably a bug then? /cc @dougbu
There was a problem hiding this comment.
@rynowak what exactly do you want my thoughts on?
There was a problem hiding this comment.
oh nvmt his is in test code. Just ignore then
Tratcher
approved these changes
Jan 23, 2019
dougbu
reviewed
Jan 23, 2019
| { | ||
| return Task.CompletedTask; | ||
| } | ||
|
|
There was a problem hiding this comment.
@rynowak what exactly do you want my thoughts on?
halter73
approved these changes
Jan 23, 2019
src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/CollectionModelBinder.cs
Outdated
Show resolved
Hide resolved
natemcmaster
approved these changes
Jan 23, 2019
benaadams
reviewed
Jan 24, 2019
src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/CollectionModelBinder.cs
Outdated
Show resolved
Hide resolved
Eilon
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3645