Revert "Wait to dispose RequestAborted CTS (#4447)" #6994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0622513.
Tratcher
approved these changes
Jan 24, 2019
natemcmaster
added
the
Servicing-consider
muratg
reviewed
Jan 24, 2019
| { | ||
| var originalToken = _http1Connection.RequestAborted; | ||
| var originalRegistration = originalToken.Register(() => { }); | ||
|
|
||
| _http1Connection.Abort(new ConnectionAbortedException()); | ||
|
|
||
| Assert.True(originalToken.WaitHandle.WaitOne(TestConstants.DefaultTimeout)); | ||
| // The following line will throw an ODE because the original CTS backing the token has been diposed. |
muratg
approved these changes
Jan 24, 2019
muratg
added
Servicing-approved
natemcmaster
approved these changes
Jan 24, 2019
dougbu
approved these changes
Jan 24, 2019
Merged
|
Can we get this in ASAP to get a build out please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0622513.