Move Cors Functional tests to a separate test group #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attemp #2 at addressing https://github.com/aspnet/AspNetCore-Internal/issues/1619 Puppetteer will attempt to download chromium as part of running the test. This seems odd, but it might explain why this might be afflicted with the file descriptor contention issues that the mondo repo tests encounter. Moving these out in to a separate test group to see if this helps Possible fix for https://github.com/aspnet/AspNetCore-Internal/issues/1619
Eilon
added
the
area-mvc
|
This build - http://aspnetci/viewLog.html?buildId=618439&buildTypeId=Releases_22xPublic_OsxUniverse - does provide clues that the timeout is from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attemp #2 at addressing https://github.com/aspnet/AspNetCore-Internal/issues/1619
Puppetteer will attempt to download chromium as part of running the test. This seems odd, but
it might explain why this might be afflicted with the file descriptor contention issues that
the mondo repo tests encounter.
Moving these out in to a separate test group to see if this helps
Possible fix for https://github.com/aspnet/AspNetCore-Internal/issues/1619