Skip to content

Introduce dynamic endpoints and fix #7011 #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2019
Merged

Introduce dynamic endpoints and fix #7011 #7445

merged 2 commits into from
Feb 14, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Feb 11, 2019

Introduces a pattern for matcher policy that replaces endpoints during matching.

This allows you to uses the matcher's URL processing, but then run arbitrary other code to choose your own endpoint.

@rynowak rynowak requested review from davidfowl and JamesNK February 11, 2019 05:40
@jkotalik jkotalik removed their request for review February 11, 2019 14:55
@Tratcher Tratcher removed their request for review February 11, 2019 19:09
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 12, 2019
@rynowak rynowak force-pushed the rynowak/dynamic-endpoint branch from 83a00c2 to 7c2c50d Compare February 12, 2019 05:36
@rynowak rynowak requested a review from pranavkm February 12, 2019 05:36
@rynowak
Copy link
Member Author

rynowak commented Feb 12, 2019 •
edited
Loading

@JamesNK @pranavkm - Updated and added some stuff.

So once I got all of this working, I realised that I had a problem because use the invoker factory from page loader creates a DI cycle. This is just a general thing we should try to avoid - ideally MVC doesn't need to construct the entire runtime just to do action discovery.

To resolve this I had to disentangle a few things... ahem removing MvcActionInvokerFactory which was a total hack. The nice thing is that we now only interact with IActionContextAccessor in one place instead of 3.

@rynowak rynowak changed the title [Design] Introduce dynamic endpoints and fix #7011 Introduce dynamic endpoints and fix #7011 Feb 12, 2019
@rynowak rynowak force-pushed the rynowak/dynamic-endpoint branch from 7c2c50d to 15d6526 Compare February 13, 2019 05:00
@rynowak
Copy link
Member Author

rynowak commented Feb 13, 2019

@JamesNK @pranavkm updated for your reviewing pleasure

@rynowak
Copy link
Member Author

rynowak commented Feb 13, 2019

@JamesNK ping

@rynowak
Copy link
Member Author

rynowak commented Feb 14, 2019

Thanks chaps!

@rynowak rynowak merged commit f2a1a45 into master Feb 14, 2019
@rynowak rynowak deleted the rynowak/dynamic-endpoint branch February 14, 2019 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@JamesNK JamesNK JamesNK approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rynowak @pranavkm @JamesNK @Eilon