Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Preview 3 - Update Razor SDK and resolve issues #7798

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Port to Preview 3 - Update Razor SDK and resolve issues #7798

merged 1 commit into from
Feb 21, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Feb 21, 2019

Adds event callback support from the compiler

(cherry picked from commit 616a4a3)

@rynowak
[wip] Update Razor SDK and resolve issues
983fbf7 
I'm still chasing one more issue.

(cherry picked from commit 616a4a3)
@rynowak
Copy link
Member Author

rynowak commented Feb 21, 2019

@mkArtakMSFT - this is porting the fix for #6351 and #5507

@rynowak rynowak changed the title Update Razor SDK and resolve issues Port to Preview 3 - Update Razor SDK and resolve issues Feb 21, 2019
dougbu
dougbu approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eng/ changes look fine to me. Please get another approval for the product code changes.

@mkArtakMSFT mkArtakMSFT merged commit ebb527d into release/3.0-preview3 Feb 21, 2019
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 21, 2019
@rynowak
Copy link
Member Author

rynowak commented Feb 21, 2019

Thanks!

@rynowak rynowak deleted the rynowak/event-callback-preview3 branch February 21, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@dougbu dougbu dougbu approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees

@mkArtakMSFT mkArtakMSFT

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rynowak @dougbu @mkArtakMSFT @Eilon