Wait to dispose RequestAborted CTS #9333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4422 |
Tratcher
reviewed
Apr 12, 2019
halter73
reviewed
Apr 12, 2019
halter73
reviewed
Apr 12, 2019
Co-Authored-By: jkotalik <jukotali@microsoft.com>
jkotalik
commented
Apr 12, 2019
|
🆙 📅 . IMO this change is ready to go |
halter73
reviewed
Apr 12, 2019
halter73
reviewed
Apr 12, 2019
halter73
reviewed
Apr 12, 2019
halter73
reviewed
Apr 12, 2019
halter73
reviewed
Apr 12, 2019
halter73
approved these changes
Apr 12, 2019
Tratcher
reviewed
Apr 12, 2019
amcasey
added
area-networking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A redo of #4447.
When we tried this PR before, it caused a pretty nasty deadlock between Reset and Cancel in HttpProcotol. This should avoid it by capturing the CTS in a local inside of the lock and then cancelling outside of the lock.
This change will eventually be applied to IIS (and then I'd probably add a helper because the pattern will be the same). However, I want to make sure this change stabilizes on CI and doesn't have flakiness.
If this change works well, we should consider porting it back to 2.2.x.