Move ResponseCaching pubternal types to internal #9392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
added
the
breaking-change
JunTaoLuo
commented
Apr 15, 2019
| @@ -30,17 +31,17 @@ public class ResponseCachingMiddleware | |||
| RequestDelegate next, | |||
| IOptions<ResponseCachingOptions> options, | |||
| ILoggerFactory loggerFactory, | |||
| IResponseCachingPolicyProvider policyProvider, | |||
| IResponseCachingKeyProvider keyProvider) | |||
| ObjectPoolProvider poolProvider) | |||
There was a problem hiding this comment.
Note that it's still necessary to resolve a ObjectPoolProvider from DI for the ResponseCachingKeyProvider (which was for perf). If/When we eventually create supported extension points, we'll need to mark this constructor as obsolete.
|
Oops need to update generated code and breaking changes. |
Tratcher
reviewed
Apr 15, 2019
src/Middleware/ResponseCaching/ref/Microsoft.AspNetCore.ResponseCaching.netcoreapp3.0.cs
Outdated
Show resolved
Hide resolved
JunTaoLuo
force-pushed
the
johluo/internalize-responsecaching-api
branch
from
be31ce7 to
ca5dab5
Compare
|
This comment was made automatically. If there is a problem contact ryanbrandenburg. I've triaged the above build. I've created/commented on the following issue(s) |
Tratcher
approved these changes
Apr 16, 2019
|
Don't forget an announcement :). |
|
Announcement: aspnet/Announcements#354 |
amcasey
added
the
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ResponseCache portions of #6975. This is a breaking change due to the constructor change of the ResponseCachingMiddleware.
Tested locally with the analyzer to ensure all response caching errors are resolved.