Fix IDX21323: RequireNonce is 'False' during token refreshClient #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://security.stackexchange.com/questions/147529/openid-connect-nonce-replay-attack and IdentityServer/IdentityServer4#2180 for the purpose of the nonce and why it's unnecessary for the token refresh
guardrex
approved these changes
Mar 9, 2024
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://security.stackexchange.com/questions/147529/openid-connect-nonce-replay-attack and IdentityServer/IdentityServer4#2180 for the purpose of the nonce and why it's unnecessary for the token refresh.
This also switches to using
OpenIdConnectOptions.Backchannelrather than its ownHttpClientso it gets an OIDC-specific user agent and includes any other customizations that might be necessary for communicating with the given OIDC provider.Fixes dotnet/aspnetcore#53585