Skip to content
This repository was archived by the owner on Feb 25, 2021. It is now read-only.

[WIP] Codegen partial classes. Implements #278 #294

Closed
wants to merge 1 commit into from

Conversation

SteveSandersonMS
Copy link
Member

Although this works fine at compile time and runtime, it doesn't work correctly at design time in VS:

image

I'm unsure why partial classes from the same project aren't included in the design-time compilation that VS is getting these errors from, especially given that things like @inherits SomeClass works fine.

@rynowak, do you know why this is, and if there's any straightforward thing we can do in this repo to fix it?

Not urgent! This doesn't need to be included in 0.1.0.

@rynowak
Copy link
Member

rynowak commented Mar 19, 2018

Ah, I see.

The problem with this is that the editor code is Fake. It mangles the class name so that it doesn't conflict with the file on disk. I'm sad that we can't do this trivially 😢

I have a few ideas for how to fix it, but they will be more involved.

@danroth27
Copy link
Member

#278

@SteveSandersonMS
Copy link
Member Author

@rynowak Since this PR is relatively simple, and the work to really enable partial might be a while off, I think I'll just close this and then we can reimplement/rediscover it later. Please reopen if you disagree.

@natemcmaster natemcmaster deleted the stevesa/278-codegen-partial-classes branch May 24, 2019 00:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants