Fix arcade signing #328
Merged
Fix arcade signing #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… days from now** automatically generated for your 1ES PT-based pipelines. Complete this pull request as soon as possible to make sure that your pipeline becomes compliant. Longer delays in completing this PR can trigger additional emails or S360 alerts in the future. 1ES PT Auto-baselining feature helps capture existing violations in your repo and ensures to break your pipeline only for newly introduced SDL violations after baselining. Running SDL tools in break mode is required for your pipeline to be compliant. Go to https://aka.ms/1espt-autobaselining for more details. **Please do not Abandon this PR.** Please reach out to 1ES PT for support. More details: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/support
edvilme
force-pushed
the
edvilme-arcade-fix
branch
3 times, most recently
from
eb6bfb4 to
8cb1aaa
Compare
Merged
edvilme
force-pushed
the
edvilme-arcade-fix
branch
6 times, most recently
from
9be73d5 to
fa70687
Compare
Add files to ItemsToSign Sign .msi file too Update `ItemsToSign` Update certificate name UseDotNetCertificate Add .msi certificatename
edvilme
force-pushed
the
edvilme-arcade-fix
branch
from
fa70687 to
85f5414
Compare
edvilme
commented
Feb 11, 2025
| <Import Project="targets\GenerateLayout.targets" /> | ||
| <Import Condition="'$(RID)' == 'win-x86'" Project="targets\FileExtensions.targets" /> | ||
| <Import Condition="'$(RID)' == 'win-x86'" Project="targets\GenerateMSIs.targets" /> | ||
| <Import Condition="'$(RID)' == 'win-x86'" Project="targets\Signing.targets" /> |
Contributor
Author
There was a problem hiding this comment.
Signing.targets no longer needed as handled by Arcade now
| <_PublishSingleFileForRid>true</_PublishSingleFileForRid> | ||
| <_PublishSingleFileForRid Condition="'$(RID)' == 'win-x86'">false</_PublishSingleFileForRid> | ||
| <_GenerateLayoutDependsOnTargets>CleanLayoutPath;PublishDotnetCoreUninstallProject</_GenerateLayoutDependsOnTargets> | ||
| <_GenerateLayoutDependsOnTargets Condition="'$(RID)' == 'win-x86'">CleanLayoutPath;PublishDotnetCoreUninstallProject;SignLayout</_GenerateLayoutDependsOnTargets> |
Contributor
Author
There was a problem hiding this comment.
SignLayout is also handled by Arcade now
Contributor
There was a problem hiding this comment.
Why did we lose the condition?
Contributor
Author
There was a problem hiding this comment.
Because it is identical to the previous line, but adds the SignLayout target (which is now unused)
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .config/guardian/.gdnbaselines: Language not supported
- eng/Signing.props: Language not supported
- src/redist/redist.csproj: Language not supported
- src/redist/targets/GenerateLayout.targets: Language not supported
- src/redist/targets/Signing.targets: Language not supported
Forgind
approved these changes
Feb 11, 2025
| <_PublishSingleFileForRid>true</_PublishSingleFileForRid> | ||
| <_PublishSingleFileForRid Condition="'$(RID)' == 'win-x86'">false</_PublishSingleFileForRid> | ||
| <_GenerateLayoutDependsOnTargets>CleanLayoutPath;PublishDotnetCoreUninstallProject</_GenerateLayoutDependsOnTargets> | ||
| <_GenerateLayoutDependsOnTargets Condition="'$(RID)' == 'win-x86'">CleanLayoutPath;PublishDotnetCoreUninstallProject;SignLayout</_GenerateLayoutDependsOnTargets> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to arcade, builds were not generating correctly.
This adds an automated PR for 1ES compliance, and removes signing targets as these are now generated automatically on Arcade
Trying to keep 8c89301 as its own commit as to preserve git history