-
Notifications
You must be signed in to change notification settings - Fork 1.1k
WIP: Avoid VT-100 output from build.sh #10051
WIP: Avoid VT-100 output from build.sh #10051
Conversation
@mmitche @livarcocc I'd like to try this as a possible workaround/information-gathering approach for the intermittent CLI hang. Ideally we wouldn't have to check it into a mainline branch and could just spin many builds of a private branch to test just this change. Is that possible? Note that I based my change on the last time |
@rainersigwald given that we have been hitting this issue in CI a lot, I would just try a few tests here on this PR itself. Just please, mark WIP in the title so that we don't accidentally merge it. |
dockerrun.sh is passing a -t argument to docker run. That will allocate a terminal and cause control codes to be emitted. |
You're right, that's resistant to the stdout of the process that calls it. Boo. I'll bury it inside run-build.sh, I guess. |
ed9ceae
to
a5fa087
Compare
@dotnet-bot test this please We see this so much that it's been getting hard to get a build through. |
@livarcocc What do you think of these failures? Related? |
@rainersigwald Just push this branch to the internal remote and I'll take care of it. |
This is an attempt to work around/isolate the cause of intermittent hangs in the CLI official build. Since the hang appears to be happening when emitting a control code to STDOUT, let's try to set STDOUT up in such a way that things mostly don't try to emit control codes to it. Related: - dotnet/msbuild#3563 - https://github.com/dotnet/corefx/issues/31559
a5fa087
to
2df4137
Compare
@mmitche I rebased onto #10147 and pushed to internal branch dev/raines/cat-build-output. |
@rainersigwald So far I haven't seen the failure with this in the build, though let's wait a little longer since not all the builds have made it through to the CLI. |
@rainersigwald I haven't seen any errors in the typical places (RHEL, Musl) though I have seen a few in arm64. Not sure whether it is the same issue. It may be worth merging this. |
Do we plan to take this or can this be closed now? |
This is an attempt to work around/isolate the cause of intermittent
hangs in the CLI official build. Since the hang appears to be happening
when emitting a control code to STDOUT, let's try to set STDOUT up in
such a way that things mostly don't try to emit control codes to it.
Related: