-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update cshtml wildcard in publishOptions #3950
Update cshtml wildcard in publishOptions #3950
Conversation
Updating the publishOptions wildcard that used to publish everything in the views folder to now publish all .cshtml files. The problem was that the old wildcard only included the Views folder and didn't include anything in the Areas/*/Views folders (used by views inside areas). This change makes things much simpler, all .csthml files are published.
Hi @rynowak, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
@rynowak Can this change be merged? Will there be any more changes needed to the templates outside of this? |
@brthor I'm not 100% sure we got approval for this change for 1.0.1.. I do believe we'll have more changes for 1.0.1 after this based on some discussions we're having. |
okay we'll hold off on this one. Thanks |
@piotrpMSFT is this something we can get into the next preview of the CLI templates? It's a small change that un-breaks publishing ASP.NET apps that use MVC "Areas". |
@piotrpMSFT is there even a 1.0.1 CLI patch to consider here? I think this just needs to go into whatever the next CLI release is, no? |
Approved by @coolcsh in person. cc @piotrpMSFT |
Does this need to go into CLI preview 2 patch - #4119? If so can we get this merged? |
@Sridhar-MS This was approved by @coolcsh. Could you please merge for the patch release? |
Fix issue #3949
Updating the publishOptions wildcard that used to publish everything in
the views folder to now publish all .cshtml files. The problem was that
the old wildcard only included the Views folder and didn't include
anything in the Areas/*/Views folders (used by views inside areas).
This change makes things much simpler, all .csthml files are published.