Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Update cshtml wildcard in publishOptions #3950

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Jul 27, 2016

Fix issue #3949

Updating the publishOptions wildcard that used to publish everything in
the views folder to now publish all .cshtml files. The problem was that
the old wildcard only included the Views folder and didn't include
anything in the Areas/*/Views folders (used by views inside areas).

This change makes things much simpler, all .csthml files are published.

Updating the publishOptions wildcard that used to publish everything in
the views folder to now publish all .cshtml files. The problem was that
the old wildcard only included the Views folder and didn't include
anything in the Areas/*/Views folders (used by views inside areas).

This change makes things much simpler, all .csthml files are published.
@dnfclas
Copy link

dnfclas commented Jul 27, 2016

Hi @rynowak, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@brthor
Copy link

brthor commented Aug 2, 2016

@rynowak Can this change be merged?

Will there be any more changes needed to the templates outside of this?

@rynowak
Copy link
Member Author

rynowak commented Aug 2, 2016

@brthor I'm not 100% sure we got approval for this change for 1.0.1.. I do believe we'll have more changes for 1.0.1 after this based on some discussions we're having.

@brthor
Copy link

brthor commented Aug 2, 2016

okay we'll hold off on this one. Thanks

@Eilon
Copy link
Member

Eilon commented Aug 12, 2016

@piotrpMSFT is this something we can get into the next preview of the CLI templates? It's a small change that un-breaks publishing ASP.NET apps that use MVC "Areas".

@TheRealPiotrP
Copy link

@Eilon per above, @brthor is waiting on confirmation from @rynowak before clicking merge :)

@Eilon
Copy link
Member

Eilon commented Aug 19, 2016

@piotrpMSFT is there even a 1.0.1 CLI patch to consider here? I think this just needs to go into whatever the next CLI release is, no?

@Eilon
Copy link
Member

Eilon commented Aug 23, 2016

Approved by @coolcsh in person.

cc @piotrpMSFT

@Sridhar-MS
Copy link

Does this need to go into CLI preview 2 patch - #4119? If so can we get this merged?

@muratg
Copy link

muratg commented Aug 31, 2016

@Sridhar-MS This was approved by @coolcsh. Could you please merge for the patch release?

@Sridhar-MS Sridhar-MS merged commit 6763893 into feature/antares Aug 31, 2016
@TheRealPiotrP TheRealPiotrP deleted the feature/antares-update-new-template-publish-wildcard branch January 24, 2017 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants