Making Project Tools use the CLI shared runtime #4814
Conversation
There was a problem hiding this comment.
The test should be updated. I'd be satisfied if we at least capture the because of why the test proves what it proves. If you can easily find a non-RTM but named version of Microsoft.NetCore.App I'd love to use that as the test case Fx, but wouldn't lose much sleep if we can't...
| new DotnetCommand() | ||
| .WithWorkingDirectory(testInstance.Root) | ||
| .ExecuteWithCapturedOutput("prefercliruntime") | ||
| .Should() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| .Should() | ||
| .Pass() | ||
| .And | ||
| .HaveStdOutContaining("Hello I prefer the cli runtime World!");; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| { | ||
| get | ||
| { | ||
| return new DirectoryInfo(Path.GetDirectoryName(GetDataFromAppDomain("FX_DEPS_FILE"))).Name; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| $"packagedcommandspecfactory: Looking for prefercliruntime file at `{preferCliRuntimePath}`"); | ||
|
|
||
| return File.Exists(preferCliRuntimePath); | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -17,7 +17,8 @@ namespace Microsoft.DotNet.Tests | |||
| { | |||
| public class GivenAProjectToolsCommandResolver : TestBase | |||
| { | |||
| private static readonly NuGetFramework s_toolPackageFramework = FrameworkConstants.CommonFrameworks.NetCoreApp10; | |||
| private static readonly NuGetFramework s_toolPackageFramework = | |||
| FrameworkConstants.CommonFrameworks.NetCoreApp10; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| { | ||
| var projectToolsCommandResolver = SetupProjectToolsCommandResolver(); | ||
|
|
||
| var testInstance = TestAssetsManager |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| { | ||
| var projectToolsCommandResolver = SetupProjectToolsCommandResolver(); | ||
|
|
||
| var testInstance = TestAssetsManager |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| result.Should().NotBeNull(); | ||
|
|
||
| result.Args.Should().NotContain("-fx-version"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…ercliruntime in the root of their package. This allows for project tools to not have to change when a new runtime comes up as long as they are compatible with the runtime that the CLI is using.
livarcocc
force-pushed
the
invoke_tool_cli_fx
branch
from
5e2edca to
d5f7efb
Compare
…er structure and missing the version part of it.
|
@dotnet-bot Test Debian8.2 x64 Debug Build |
|
@MattGertz and @srivatsn for approval. |
…idation for one of the tests.
|
@dotnet-bot Test CentOS7.1 x64 Debug Build |
|
Ping @MattGertz @srivatsn for approval |
Making Project Tools use the CLI shared runtime if they have the prefercliruntime in the root of their package. This allows for project tools to not have to change when a new runtime comes up as long as they are compatible with the runtime that the CLI is using.
@piotrpMSFT @krwq @jgoshi