Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Updating Roslyn to 2.7.0-beta3-62529-05. #8498

Merged
merged 3 commits into from
Feb 5, 2018

Conversation

livarcocc
Copy link

No description provided.

@livarcocc livarcocc requested a review from a team January 29, 2018 22:18
@livarcocc
Copy link
Author

@jaredpar this is for 15.6.

@dasMulli
Copy link

Is there any danger of beta 7.3 language features lighting up for LangVersion=Latest projects only in the 15.6 CLI but not in 15.6 VS with this 2.7 package?

@jaredpar
Copy link
Member

@dasMulli

Is there any danger of beta 7.3 language features lighting up for LangVersion=Latest projects only in the 15.6 CLI but not in 15.6 VS with this 2.7 package?

No. C# 7.3 isn't included in 15.6, or this package, hence won't show up due to this package.

The more general question though:

Is there any danger of language features working from a CLI build but having squiggles inside VS

Yes that can happen. If you have a CLI that supports a language newer than the one in VS then you can get into this error. Thats true for both Latest and explicitly set versions.

@dasMulli
Copy link

Thanks, I think I just got confused by roslyn version numbers. (just seen that there are 2.8 packages now as well).

@livarcocc livarcocc added this to the 2.1.3xx milestone Jan 30, 2018
@livarcocc
Copy link
Author

@dotnet-bot Test Ubuntu x64 Release Build

@@ -84,6 +84,7 @@
<RoslynDeps Include="$(RoslynDirectory)/bincore/csc.deps.json" />
<RoslynDeps Include="$(RoslynDirectory)/bincore/vbc.deps.json" />
<RoslynSatelliteDeps Include="$(RoslynDirectory)/bincore/tool_roslyn_satellites.deps.json" />
<RoslynFrameworkAssemblies Include="$(RoslynDirectory)/System.*.dll;$(RoslynDirectory)/runtimes/**/System.*.dll" Exclude="$(RoslynDirectory)/runtimes/**/System.IO.Pipes.AccessControl.dll"/>

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@nguerrera nguerrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to understand about the framework assemblies

@nguerrera
Copy link
Contributor

@MattGertz for approval of Roslyn insertion in to CLI for 15.6 P4. I will hold on merging until I understand the issue with framework assemblies, though.

@MattGertz
Copy link

Proactively approving.

@livarcocc
Copy link
Author

@nguerrera are you satisfied with this change now? Have you filed an issue against Roslyn? I intended to, but then the flu got me.

@nguerrera
Copy link
Contributor

Haven't filed the issue. I will do so. I am satisfied if we're tracking it as a temporary workaround against a roslyn bug.

@nguerrera nguerrera merged commit cdf3901 into dotnet:release/2.1.1xx Feb 5, 2018
@nguerrera
Copy link
Contributor

Filed dotnet/roslyn#24646

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants